[MdRefresh/NTP] The text "Search Google ..." in the Fake Search Box expands/shrinks during opening a NTP |
|||||||
Issue descriptionChrome Version: Canary Version 69.0.3494.0 OS: macOS, but probably OS=All What steps will reproduce the problem? (1) Enable #upcoming-ui-features (2) Open a New Tab Page (3) Take a look at the Fake Search Box What is the expected result? The text "Search Google ..." should not expand/shrink. What happens instead? The text "Search Google ..." expands/shrinks. A screencast is attached. Thanks Mehmet
,
Jul 17
This happens because the page first renders with the old font (non-GM2 styling), then updates to the new font (GM2 styling) after checking the flag. It's hard to reproduce as it depends both on the page load time and (maybe?) some caching.
,
Jul 17
Hmm.. I can repro on latest Chromium Snapshot but not in Canary. Here is my variations from my Chromium Build: c134752e-f685ead3 2c707b42-782e0fe9 d01ab0d3-3a02fa78 1a0d11d4-3f4a17df 16e0dd70-3f4a17df ebeb14fc-3f4a17df b7e2524c-3f4a17df b3888d8d-afba0f91 3cd9377c-5dc629f0 6c18ba9d-3d98b302 64da5c1e-2c5b253d 61832c80-3f4a17df 9041608a-3f4a17df 241fff6c-4eda1c57 1e528f0f-15305a2 9853922b-3f4a17df 125b7f68-3f4a17df 1c752ce9-1c752ce9 1149accc-3f4a17df 776de70c-e0278d3d ed9149a9-3f4a17df 34d450b1-3f4a17df 31362330-3f4a17df c70841c8-a2567007 67a989a4-7dd0ee42 ed7ba060-3f4a17df 9e201a2b-3f4a17df 27212adc-27212adc 5274eb09-3f4a17df ceff87ec-3f4a17df 44827ee5-3f4a17df 332a4d9b-8e8e4a2b d0ecf1da-3f4a17df 8f1e27f-3f4a17df edbcf7c5-51ca58f3 77bbdddc-3f4a17df 5485fc4d-3f4a17df 93731dca-3f4a17df 43f62d3b-3f4a17df 9e5c75f1-30e1b12b 2981bcb4-3f4a17df 3de1fbf2-3f4a17df 5139837c-3f4a17df 7f8176d9-3f4a17df 23a898eb-fc93cf74 7a5ba892-3f4a17df 4ea303a6-3f4a17df b19465ab-b19465ab 6e6e0c7e-3f17a7d8 d92562a9-9c93b39 2b33233e-881ca6c9 4da5ae82-3f4a17df 56302f8c-2f882e70 14c5a050-61ceed18 2c1d398c-3f4a17df 6973a1cf-3f4a17df 72606c4f-3f4a17df b2612322-8a9180b2 ad6d27cc-3e870323 2a32876a-b7b6ded0 ff29b1bd-289a0ebc f56e0452-3f4a17df da460ac8-3f4a17df 4bc337ce-535cb40a 9a2f4e5b-3f4a17df d747916f-d747916f 1354da85-522c33b8 17507c76-3f4a17df 494d8760-3f4a17df 34baa302-cf4f6ead 587fa7b2-726d8ace bbb8f811-3f4a17df 94e68624-803f8fc4 cc73f8a1-3f4a17df de384ee6-7652bd75 8834fcca-3f4a17df 11d91db8-d93a0620 493ac2c5-803f8fc4 May be it helps? Also, I am using a Non-Retina MacBook Air.
,
Jul 17
If it's a flag loading delay, wouldn't the text in the fakebox change too? "Mit Google suchen oder eine URL eingeben" (http://tc/btviewer/messagedetail?project=gws&msgId=6478791167930180244) vs "In Google suchen oder URL eingeben" (http://tc/btviewer/messagedetail?project=gws&msgId=46450)
,
Jul 17
The text is determined before the page renders, in local_ntp_source.cc, and is then set unconditionally in local_ntp.js init(). The font style is changed by toggling on the MD class in init() if the flag is enabled.
,
Jul 17
,
Jul 18
Ah, it does sound like it'll be hard to reproduce!
,
Jul 19
,
Jul 19
Is there anything for us to do here or do we want to just wait it out until GM2 styling is default?
,
Jul 19
I think we should just wait it out. The issue won't go away until the old styling is removed completely, not just when the GM2 flag is on by default.
,
Jul 19
Cool, I'll keep the bug open then to close once old styling is gone
,
Aug 28
,
Sep 7
,
Sep 20
,
Sep 26
,
Oct 1
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d1129207318404947f13c4a3d0038c3e042a176 commit 5d1129207318404947f13c4a3d0038c3e042a176 Author: Kyle Milka <kmilka@chromium.org> Date: Tue Oct 02 19:45:36 2018 [NTP] Remove UI MD flag Remove flag for ntp md ui. Change the new styling to be the default and remove the md class, this mainly affects the fakebox as the icons are styled via md-icons. Bug: 864673 Change-Id: I7eb5da522a657417c527e3aa666bab14f8485bef Reviewed-on: https://chromium-review.googlesource.com/1255600 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#595953} [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/about_flags.cc [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/flag_descriptions.h [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/resources/local_ntp/most_visited_single.css [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/resources/local_ntp/most_visited_single.js [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/search/ntp_features.cc [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/search/ntp_features.h [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/browser/ui/search/local_ntp_browsertest.cc [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/chrome/test/data/local_ntp/local_ntp_browsertest.js [modify] https://crrev.com/5d1129207318404947f13c4a3d0038c3e042a176/testing/variations/fieldtrial_testing_config.json
,
Oct 2
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1420ce2bd1eb6891bf529a2660812fc1a4c0184 commit d1420ce2bd1eb6891bf529a2660812fc1a4c0184 Author: Kyle Milka <kmilka@chromium.org> Date: Fri Oct 05 18:33:41 2018 Revert "[NTP] Remove UI MD flag" This reverts commit 5d1129207318404947f13c4a3d0038c3e042a176. Reason for revert: Broke old UI and we probably won't be able to completely remove the old UI in M71. Original change's description: > [NTP] Remove UI MD flag > > Remove flag for ntp md ui. Change the new styling to be the > default and remove the md class, this mainly affects the fakebox > as the icons are styled via md-icons. > > Bug: 864673 > Change-Id: I7eb5da522a657417c527e3aa666bab14f8485bef > Reviewed-on: https://chromium-review.googlesource.com/1255600 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595953} TBR=isherman@chromium.org,kristipark@chromium.org,kmilka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864673 Change-Id: I5ef13705787953e96b7e4b0ead21e1e8aeb558d1 Reviewed-on: https://chromium-review.googlesource.com/c/1265024 Reviewed-by: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597206} [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/about_flags.cc [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/flag_descriptions.h [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/resources/local_ntp/most_visited_single.css [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/resources/local_ntp/most_visited_single.js [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/search/ntp_features.cc [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/search/ntp_features.h [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/browser/ui/search/local_ntp_browsertest.cc [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/chrome/test/data/local_ntp/local_ntp_browsertest.js [modify] https://crrev.com/d1420ce2bd1eb6891bf529a2660812fc1a4c0184/testing/variations/fieldtrial_testing_config.json |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ramyan@chromium.org
, Jul 17