Tricium posts comments about unittests access to a protected member |
||
Issue descriptionSample CL: https://chromium-review.googlesource.com/c/infra/infra/+/1125313 Tricium posts comments about unittests access to a protected member, while those tests are testting that protected function, which should be acceptable.
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/46eb7f79b372cf10ef03ae931c1445bc7dd60fe5 commit 46eb7f79b372cf10ef03ae931c1445bc7dd60fe5 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Jul 18 18:49:37 2018 [tricium] Disable some warning types in Pylint Currently, the Pylint analyzer always uses the bundled pylintrc and doesn't look for any project/repo/directory-specific pylintrc. This disables more warnings, including protected-access; and, based on the pylintrc in depot_tools, this CL also proposes disabling: abstract-class-little-used, abstract-class-not-used, bad-builtin, bad-inline-option, broad-except, deprecated-module, duplicate-code, exec-used, invalid-name, logging-not-lazy, reimported, too-few-public-methods, too-many-ancestors, too-many-arguments, too-many-branches, too-many-instance-attributes, too-many-lines, too-many-locals, too-many-public-methods, too-many-return-statements, too-many-statements, trailing-whitespace, Bug: 864671 Change-Id: Ibfea9c06081d5932da26474f120061f008f24a07 Reviewed-on: https://chromium-review.googlesource.com/1140896 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/46eb7f79b372cf10ef03ae931c1445bc7dd60fe5/go/src/infra/tricium/functions/pylint/pylintrc
,
Jul 18
New version of pylint deployed, the above warnings should now be disabled. |
||
►
Sign in to add a comment |
||
Comment 1 by qyearsley@google.com
, Jul 17Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)