New issue
Advanced search Search tips

Issue 864671 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tricium posts comments about unittests access to a protected member

Project Member Reported by chanli@chromium.org, Jul 17

Issue description

Sample CL: https://chromium-review.googlesource.com/c/infra/infra/+/1125313

Tricium posts comments about unittests access to a protected member, while those tests are testting that protected function, which should be acceptable.
 
Cc: -qyears...@chromium.org
Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
 1. There's currently not yet any good way of doing project-specific pylint warning config, which is what we want later; this is  bug 864685 .
 2. "# pylint: disable=" pragmas should still work though.
 3. We might want to disable a bunch of warnings that have potential to be noisy for now, included probably protected-access; uploaded https://chromium-review.googlesource.com/c/infra/infra/+/1140896.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/46eb7f79b372cf10ef03ae931c1445bc7dd60fe5

commit 46eb7f79b372cf10ef03ae931c1445bc7dd60fe5
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Jul 18 18:49:37 2018

[tricium] Disable some warning types in Pylint

Currently, the Pylint analyzer always uses the bundled pylintrc
and doesn't look for any project/repo/directory-specific pylintrc.

This disables more warnings, including protected-access; and,
based on the pylintrc in depot_tools, this CL also proposes
disabling:

      abstract-class-little-used,
      abstract-class-not-used,
      bad-builtin,
      bad-inline-option,
      broad-except,
      deprecated-module,
      duplicate-code,
      exec-used,
      invalid-name,
      logging-not-lazy,
      reimported,
      too-few-public-methods,
      too-many-ancestors,
      too-many-arguments,
      too-many-branches,
      too-many-instance-attributes,
      too-many-lines,
      too-many-locals,
      too-many-public-methods,
      too-many-return-statements,
      too-many-statements,
      trailing-whitespace,

Bug:  864671 
Change-Id: Ibfea9c06081d5932da26474f120061f008f24a07
Reviewed-on: https://chromium-review.googlesource.com/1140896
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/46eb7f79b372cf10ef03ae931c1445bc7dd60fe5/go/src/infra/tricium/functions/pylint/pylintrc

Status: Fixed (was: Assigned)
New version of pylint deployed, the above warnings should now be disabled.

Sign in to add a comment