New issue
Advanced search Search tips

Issue 864618 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 855609



Sign in to add a comment

WidgetTestInteractive.ExitFullscreenRestoreState fails flakily in views_mus_interactive_ui_tests with WS2

Project Member Reported by msw@chromium.org, Jul 17

Issue description

WidgetTestInteractive.ExitFullscreenRestoreState fails flakily in views_mus_interactive_ui_tests with WS2

See work to use test_ws / ws2 in views_mus_interactive_ui_tests here:
  https://chromium-review.googlesource.com/c/chromium/src/+/1138749

[ RUN      ] WidgetTestInteractive.ExitFullscreenRestoreState
[193996:194080:0717/100545.037461:3969444099132:INFO:service_process_launcher.cc(200)] Launched child process pid=194090, instance=, name=test_ws, user_id=505C0EE9-3013-43C0-82B0-A84F50CF8D84
[194090:194090:0717/100545.225321:3969444287155:ERROR:window_service.cc(30)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindEventInjectorRequest(ui::mojom::EventInjectorRequest)
[194090:194090:0717/100545.225691:3969444287345:ERROR:window_service.cc(34)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindGpuRequest(ui::mojom::GpuRequest)
[194090:194090:0717/100545.225867:3969444287520:ERROR:window_service.cc(34)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindGpuRequest(ui::mojom::GpuRequest)
[194090:194090:0717/100545.225995:3969444287649:ERROR:window_service.cc(39)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindDiscardableSharedMemoryManagerRequest(discardable_memory::mojom::DiscardableSharedMemoryManagerRequest)
[194090:194090:0717/100545.231313:3969444292965:ERROR:window_tree.cc(1316)] Not implemented reached in virtual void ui::ws2::WindowTree::SetHitTestMask(ui::Id, const base::Optional<gfx::Rect> &)
../../ui/views/widget/widget_interactive_uitest.cc:1346: Failure
Expected equality of these values:
  ui::SHOW_STATE_NORMAL
    Which is: 1
  GetWidgetShowState(toplevel)
    Which is: 4
Stack trace:
#0 0x00000047f62c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x00000047f009 testing::internal::AssertHelper::operator=()
#2 0x000000456d5d views::test::WidgetTestInteractive_ExitFullscreenRestoreState_Test::TestBody()

../../ui/views/widget/widget_interactive_uitest.cc:1354: Failure
Expected equality of these values:
  ui::SHOW_STATE_NORMAL
    Which is: 1
  GetWidgetShowState(toplevel)
    Which is: 4
Stack trace:
#0 0x00000047f62c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x00000047f009 testing::internal::AssertHelper::operator=()
#2 0x000000457164 views::test::WidgetTestInteractive_ExitFullscreenRestoreState_Test::TestBody()

[  FAILED  ] WidgetTestInteractive.ExitFullscreenRestoreState (234 ms)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513

commit 9c3b6f47c4e7f96ec9cb6525801f06ea989f6513
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Jul 26 00:39:29 2018

ws2: Add test_ws top level windows to the AuraTestHelper's root.

Re-enable several tests that were broken without this change:
  DesktopWindowTreeHostMusTest.Deactivate
  DesktopWindowTreeHostMusTest.StackAbove
  WidgetTestInteractive.ExitFullscreenRestoreState
  WidgetObserverTest.ActivationChange
(WindowTree::SetFocus would fail and revert without a root window)
(tests mayby passed flakily by not getting revert responses in time)

Add logging; remove unused WidgetObserverTest widget; cleanup.

Bug:  864614 ,  864615 ,  864618 ,  864800 
Test: automated tests don't flake (passed 100+ runs for me)
Change-Id: Idf34e6b4cae9a268eb580ecdbadb023da711b102
Reviewed-on: https://chromium-review.googlesource.com/1149087
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578147}
[modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/services/ui/test_ws/test_ws.cc
[modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/services/ui/ws2/focus_handler.cc
[modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/aura/mus/in_flight_change.cc
[modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/aura/mus/in_flight_change.h
[modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/views/widget/widget_unittest.cc

Status: Fixed (was: Available)

Sign in to add a comment