DragTestInteractive.DragTest hangs in views_mus_interactive_ui_tests with WS2 |
|||
Issue descriptionDragTestInteractive.DragTest hangs in views_mus_interactive_ui_tests with WS2 See work to use test_ws / ws2 in views_mus_interactive_ui_tests here: https://chromium-review.googlesource.com/c/chromium/src/+/1138749 [ RUN ] DragTestInteractive.DragTest [195810:195813:0717/100923.586102:3969662648054:INFO:service_process_launcher.cc(200)] Launched child process pid=195823, instance=, name=test_ws, user_id=505C0EE9-3013-43C0-82B0-A84F50CF8D84 [195823:195823:0717/100923.782153:3969662843891:ERROR:window_service.cc(30)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindEventInjectorRequest(ui::mojom::EventInjectorRequest) [195823:195823:0717/100923.782339:3969662843989:ERROR:window_service.cc(34)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindGpuRequest(ui::mojom::GpuRequest) [195823:195823:0717/100923.782456:3969662844106:ERROR:window_service.cc(34)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindGpuRequest(ui::mojom::GpuRequest) [195823:195823:0717/100923.782522:3969662844172:ERROR:window_service.cc(39)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindDiscardableSharedMemoryManagerRequest(discardable_memory::mojom::DiscardableSharedMemoryManagerRequest) [195823:195823:0717/100923.800747:3969662862397:ERROR:window_tree.cc(1316)] Not implemented reached in virtual void ui::ws2::WindowTree::SetHitTestMask(ui::Id, const base::Optional<gfx::Rect> &) Still waiting for the following processes to finish: out/Default/views_mus_interactive_ui_tests --gtest_filter=DragTestInteractive.DragTest --gtest_flagfile=/tmp/.org.chromium.Chromium.7LM7Hb/.org.chromium.Chromium.M2jdGs --single-process-tests --test-launcher-output=/tmp/.org.chromium.Chromium.4I63JU/test_results.xml
,
Jul 24
I suspect we need to have services/ui/ws2/test_ws implement the dnd related functions RunDragLoop/CancelDragLoop.
,
Jul 26
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1152461
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bda4d62eb5fca973c1fa95212d9149958965664 commit 6bda4d62eb5fca973c1fa95212d9149958965664 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Jul 27 17:22:31 2018 ws2: Re-enable DragTestInteractive.DragTest - Add TestDragDropClient based on ash::DragDropController to map mouse events to DragTargetEvents and dispatch them; - Implement RunDragLoop/CancelDragLoop in test_ws using TestDragDropClient; - Re-enable RunDragLoop/CancelDragLoop; Bug: 864616 Change-Id: I349e5c80abe8f20e27a5da34992c15cc611a98b3 Reviewed-on: https://chromium-review.googlesource.com/1152461 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#578690} [modify] https://crrev.com/6bda4d62eb5fca973c1fa95212d9149958965664/services/ui/test_ws/BUILD.gn [add] https://crrev.com/6bda4d62eb5fca973c1fa95212d9149958965664/services/ui/test_ws/test_drag_drop_client.cc [add] https://crrev.com/6bda4d62eb5fca973c1fa95212d9149958965664/services/ui/test_ws/test_drag_drop_client.h [modify] https://crrev.com/6bda4d62eb5fca973c1fa95212d9149958965664/services/ui/test_ws/test_ws.cc [modify] https://crrev.com/6bda4d62eb5fca973c1fa95212d9149958965664/ui/views/mus/drag_interactive_uitest.cc
,
Jul 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sky@chromium.org
, Jul 24Status: Assigned (was: Available)