DesktopWindowTreeHostMusTest.Deactivate fails flakily in views_mus_unittests with WS2 |
||
Issue descriptionDesktopWindowTreeHostMusTest.Deactivate fails flakily in views_mus_unittests with WS2 See work to use test_ws / ws2 in views_mus_unittests here: https://chromium-review.googlesource.com/c/chromium/src/+/1138749 [ RUN ] DesktopWindowTreeHostMusTest.Deactivate [176717:185077:0717/095623.174177:3968882235834:INFO:service_process_launcher.cc(200)] Launched child process pid=185093, instance=, name=test_ws, user_id=505C0EE9-3013-43C0-82B0-A84F50CF8D84 [185093:185093:0717/095623.422293:3968882484029:ERROR:window_service.cc(30)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindEventInjectorRequest(ui::mojom::EventInjectorRequest) [185093:185093:0717/095623.422538:3968882484189:ERROR:window_service.cc(34)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindGpuRequest(ui::mojom::GpuRequest) [185093:185093:0717/095623.422704:3968882484354:ERROR:window_service.cc(34)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindGpuRequest(ui::mojom::GpuRequest) [185093:185093:0717/095623.422823:3968882484473:ERROR:window_service.cc(39)] Not implemented reached in void ui::ws2::(anonymous namespace)::BindDiscardableSharedMemoryManagerRequest(discardable_memory::mojom::DiscardableSharedMemoryManagerRequest) [185093:185093:0717/095623.425589:3968882487240:ERROR:window_tree.cc(1316)] Not implemented reached in virtual void ui::ws2::WindowTree::SetHitTestMask(ui::Id, const base::Optional<gfx::Rect> &) ../../ui/views/mus/desktop_window_tree_host_mus_unittest.cc:172: Failure Value of: widget1->IsActive() Actual: false Expected: true Stack trace: #0 0x0000006e147c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000006e0e59 testing::internal::AssertHelper::operator=() #2 0x0000004a689c views::DesktopWindowTreeHostMusTest_Deactivate_Test::TestBody() ../../ui/views/mus/desktop_window_tree_host_mus_unittest.cc:173: Failure Value of: widget1->GetNativeWindow()->HasFocus() Actual: false Expected: true Stack trace: #0 0x0000006e147c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000006e0e59 testing::internal::AssertHelper::operator=() #2 0x0000004a69b9 views::DesktopWindowTreeHostMusTest_Deactivate_Test::TestBody() ../../ui/views/mus/desktop_window_tree_host_mus_unittest.cc:174: Failure Expected equality of these values: widget_activated() Which is: NULL widget1.get() Which is: 0x157f2c1e23c0 Stack trace: #0 0x0000006e147c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000006e0e59 testing::internal::AssertHelper::operator=() #2 0x0000004a6b4a views::DesktopWindowTreeHostMusTest_Deactivate_Test::TestBody() [ FAILED ] DesktopWindowTreeHostMusTest.Deactivate (277 ms)
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513 commit 9c3b6f47c4e7f96ec9cb6525801f06ea989f6513 Author: Mike Wasserman <msw@chromium.org> Date: Thu Jul 26 00:39:29 2018 ws2: Add test_ws top level windows to the AuraTestHelper's root. Re-enable several tests that were broken without this change: DesktopWindowTreeHostMusTest.Deactivate DesktopWindowTreeHostMusTest.StackAbove WidgetTestInteractive.ExitFullscreenRestoreState WidgetObserverTest.ActivationChange (WindowTree::SetFocus would fail and revert without a root window) (tests mayby passed flakily by not getting revert responses in time) Add logging; remove unused WidgetObserverTest widget; cleanup. Bug: 864614 , 864615 , 864618 , 864800 Test: automated tests don't flake (passed 100+ runs for me) Change-Id: Idf34e6b4cae9a268eb580ecdbadb023da711b102 Reviewed-on: https://chromium-review.googlesource.com/1149087 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578147} [modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/services/ui/test_ws/test_ws.cc [modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/services/ui/ws2/focus_handler.cc [modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/aura/mus/in_flight_change.cc [modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/aura/mus/in_flight_change.h [modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/views/mus/desktop_window_tree_host_mus_unittest.cc [modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/views/widget/widget_interactive_uitest.cc [modify] https://crrev.com/9c3b6f47c4e7f96ec9cb6525801f06ea989f6513/ui/views/widget/widget_unittest.cc
,
Jul 26
|
||
►
Sign in to add a comment |
||
Comment 1 by msw@chromium.org
, Jul 17