New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864612 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] Remove support for Company name

Project Member Reported by ma...@chromium.org, Jul 17

Issue description

"Organization" or "company name" field creates more confusion than it is useful. We should deprecate support for it.


 
Owner: jeffreycohen@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd

commit 05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd
Author: Jeffrey Cohen <jeffreycohen@chromium.org>
Date: Wed Aug 15 20:49:17 2018

Add feature flag for deprecating company name

Bug: 864612
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5781f919f5903b78f5e922ad9774f9734513de97
Reviewed-on: https://chromium-review.googlesource.com/1173154
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583384}
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/chrome/browser/about_flags.cc
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/components/autofill/core/browser/contact_info.cc
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/05cdafa39c9f51145e1d3b0d25536ce20b9cd1cd/tools/metrics/histograms/enums.xml

Labels: Needs-Feedback
Tried testing the issue on build without fix #69.0.3493.0 and latest canary version #70.0.3524.0 using Mac OS 10.13.6, by following the below steps.
Steps:
=====
1. Launched chrome.
2. Navigated to Chrome://setting >> Autofill Forms 
3. Clicked on address 
As we are able to see the "Organization" on latest chrome 70.0.3524.0
Attached screen-casts for reference.
mathp@chromium.org: Could you please review the attached screen-casts and help us in verifying the fix.

Thanks.!
864612.mp4
720 KB View Download
The previous commit is just a small change to add a feature flag that will allow company name to be removed in a piecemeal fassion. It does not fix the bug yet. 
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a6fe06119f406f638c25fdae9122660b0df1a73

commit 9a6fe06119f406f638c25fdae9122660b0df1a73
Author: Jeffrey Cohen <jeffreycohen@chromium.org>
Date: Fri Aug 17 14:48:24 2018

added basic unit test around AutofillEnableCompanyName feature flag

Bug: 864612
Change-Id: I353668033e7144714fdfc8327f9cd46962e0b22c
Reviewed-on: https://chromium-review.googlesource.com/1176737
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584062}
[modify] https://crrev.com/9a6fe06119f406f638c25fdae9122660b0df1a73/components/autofill/core/browser/contact_info_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d1a29887fdd0dd26508699e5895c724e3410233

commit 7d1a29887fdd0dd26508699e5895c724e3410233
Author: Jeffrey Cohen <jeffreycohen@chromium.org>
Date: Tue Aug 28 16:53:13 2018

Use feature flag `kAutofillEnableCompanyName` to remove company names from autofill html

Bug: 864612
Change-Id: Ic7ee974224264eb15089c1915c660957592c4fc0
Reviewed-on: https://chromium-review.googlesource.com/1180418
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586747}
[modify] https://crrev.com/7d1a29887fdd0dd26508699e5895c724e3410233/chrome/browser/autofill/autofill_browsertest.cc
[modify] https://crrev.com/7d1a29887fdd0dd26508699e5895c724e3410233/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
[modify] https://crrev.com/7d1a29887fdd0dd26508699e5895c724e3410233/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Cc: krajshree@chromium.org ma...@chromium.org
 Issue 727740  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a988099e3cc72146df4513290eac1712f4ec097

commit 8a988099e3cc72146df4513290eac1712f4ec097
Author: Jeffrey Cohen <jeffreycohen@chromium.org>
Date: Mon Sep 10 20:53:40 2018

Enable/Disable filling of COMPANY_NAME using flag

Instead of COMPANY_NAME returning an empty string when disabled, this CL
enable/disables the filling of COMPANY_NAME within the fill logic.

Bug: 864612
Change-Id: I9437e45a056d110d4e3c36ac92f8ac01338b8344
Reviewed-on: https://chromium-review.googlesource.com/1205106
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590053}
[modify] https://crrev.com/8a988099e3cc72146df4513290eac1712f4ec097/chrome/browser/autofill/autofill_browsertest.cc
[modify] https://crrev.com/8a988099e3cc72146df4513290eac1712f4ec097/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/8a988099e3cc72146df4513290eac1712f4ec097/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/8a988099e3cc72146df4513290eac1712f4ec097/components/autofill/core/browser/contact_info.cc
[modify] https://crrev.com/8a988099e3cc72146df4513290eac1712f4ec097/components/autofill/core/browser/contact_info_unittest.cc
[modify] https://crrev.com/8a988099e3cc72146df4513290eac1712f4ec097/components/autofill/core/common/autofill_features.cc

currently adding a finch config to roll out disabling the flag kAutofillEnableCompanyName 
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79a090de2137853c16389cbe57ecf8143d123bc

commit a79a090de2137853c16389cbe57ecf8143d123bc
Author: Jeffrey Cohen <jeffreycohen@chromium.org>
Date: Wed Sep 12 16:07:27 2018

update tests to handle company name being disabled by default.

Ensure that Try jobs pass when the Company name flag is disabled.

Bug: 864612
Change-Id: I5ad524df35752a77be8fc704f3afb5ae48d31ed9
Reviewed-on: https://chromium-review.googlesource.com/1217449
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590706}
[modify] https://crrev.com/a79a090de2137853c16389cbe57ecf8143d123bc/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/a79a090de2137853c16389cbe57ecf8143d123bc/chrome/test/data/webui/settings/autofill_section_test.js

Labels: -M-70 M-71
Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Owner: se...@chromium.org
Status: Assigned (was: Started)
assigning to sebsg@ to handle the ios and android settings pages.

Sign in to add a comment