New issue
Advanced search Search tips

Issue 864606 link

Starred by 4 users
Status: Fixed
Owner:
cthomp@chromium.org
Closed: Jul 23
Cc:
emilyschechter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature
Team-Security-UX



Sign in to add a comment

Default to lock-only for HTTPS sites

Project Member Reported by cthomp@chromium.org, Jul 17 
For M69, we want to switch to default to only showing the lock icon in the omnibox for standard HTTPS sites.

I'll have a CL up soon.

[To the best of my knowledge, we didn't have a ticket yet for this work, so I'm making a new one.]

emilyschechter@ Do you know if there was any other work required for this change beyond changing the default condition from the EV study (Issue 803138)?
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebdf192babb3aa96113917e119310e9643fd80ae

commit ebdf192babb3aa96113917e119310e9643fd80ae
Author: Christopher Thompson <cthomp@chromium.org>
Date: Tue Jul 17 22:09:18 2018

Change default HTTPS security indicator to lock-only

This changes the default HTTPS security indicator to drop the "Secure"
verbose chip and only show the lock icon (for non-EV HTTPS).

This also updates the flag groups from crbug.com/803138 to account for
the new default, and add a "holdback" condition. The SecurityIndicatorTest
tests are updated to match.

Bug:  864606 
Change-Id: I08acd2dc9431f8b70d6f932c977a831111d08e75
Reviewed-on: https://chromium-review.googlesource.com/1140674
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575794}
[modify] https://crrev.com/ebdf192babb3aa96113917e119310e9643fd80ae/chrome/browser/about_flags.cc
[modify] https://crrev.com/ebdf192babb3aa96113917e119310e9643fd80ae/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/ebdf192babb3aa96113917e119310e9643fd80ae/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc
[modify] https://crrev.com/ebdf192babb3aa96113917e119310e9643fd80ae/components/toolbar/toolbar_field_trial.cc
[modify] https://crrev.com/ebdf192babb3aa96113917e119310e9643fd80ae/components/toolbar/toolbar_field_trial.h
[modify] https://crrev.com/ebdf192babb3aa96113917e119310e9643fd80ae/components/toolbar/toolbar_model_impl.cc

Comment 2 by cthomp@chromium.org, Jul 23

Status: Fixed (was: Started)
►

Sign in to add a comment