Chrome OS crashes when the new Account Manager is enabled |
|||
Issue descriptionOS: Chrome OS Dev (>= 69.0.3494.0) Relevant regression commit : https://chromium-review.googlesource.com/c/chromium/src/+/1091533 What steps will reproduce the problem? (1) Enable Account Manager on Chrome OS by adding the command line flag "ChromeOSAccountManager" What is the expected result? Account Manager should be enabled. What happens instead? Chrome crashes.
,
Jul 17
Root Cause: The ChromeOS OAuth Delegate (ChromeOSOAuth2TokenServiceDelegate) needs to override |OAuth2TokenServiceDelegate::GetURLLoaderFactory()| otherwise the base class returns a |nullptr| which causes OAuth access token fetches to crash : https://cs.chromium.org/chromium/src/google_apis/gaia/oauth2_token_service_delegate.cc?l=102&rcl=0e2b3d754db6f567675e9c58d53e195a38765983
,
Jul 17
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44a01c0057917e535fcfc062532b9ace85a99849 commit 44a01c0057917e535fcfc062532b9ace85a99849 Author: Kush Sinha <sinhak@chromium.org> Date: Tue Jul 17 19:49:05 2018 [Bugfix] Fix network::SimpleURLLoader migration Correctly migrate the usages of |net::URLRequestContext| to |network::SimpleURLLoader| in: - Chrome OS Account Manager - Chrome OS OAuth Delegate - Chrome OS Account Manager's account addition page This basically reverts (and migrates) parts of http://crrev.com/c/1091533 and re-lands parts of http://crrev.com/c/1105777 Bug: 864605 , 820046 Change-Id: I921dbb4c5fbf4ea9801d80d20ce1c96718eddc4b Reviewed-on: https://chromium-review.googlesource.com/1140714 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575748} [modify] https://crrev.com/44a01c0057917e535fcfc062532b9ace85a99849/chrome/browser/chromeos/oauth2_token_service_delegate.cc [modify] https://crrev.com/44a01c0057917e535fcfc062532b9ace85a99849/chrome/browser/chromeos/oauth2_token_service_delegate.h [modify] https://crrev.com/44a01c0057917e535fcfc062532b9ace85a99849/chrome/browser/ui/webui/signin/inline_login_handler_chromeos.cc [modify] https://crrev.com/44a01c0057917e535fcfc062532b9ace85a99849/chromeos/account_manager/account_manager.cc [modify] https://crrev.com/44a01c0057917e535fcfc062532b9ace85a99849/chromeos/account_manager/account_manager.h
,
Jul 18
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sinhak@chromium.org
, Jul 17