New issue
Advanced search Search tips

Issue 864595 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Make bookmark bar padding more robust to different button heights.

Project Member Reported by cyan@chromium.org, Jul 17

Issue description

Investigate interactions between all the margin, padding, heights to see if any of the ints can be cleaned up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c86ba838fcfac0de766c5448a2dc5a35c28ca18

commit 8c86ba838fcfac0de766c5448a2dc5a35c28ca18
Author: Charlene Yan <cyan@chromium.org>
Date: Wed Aug 08 15:52:05 2018

Center bookmark bar icons.

Simplifying the button padding calculation for the bookmark bar. Checks that it is appropriately centered in attached and detached state as well as with and without an info bar and tab switching.

Bug:  865555 ,  864595 ,  863697 
Change-Id: I4550c65af596d51ca41b7ac3be2c8f14825e304f
Reviewed-on: https://chromium-review.googlesource.com/1155369
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581574}
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/frame/browser_view_layout.cc
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/frame/browser_view_layout.h
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/frame/browser_view_unittest.cc
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/frame/contents_layout_manager.cc
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/frame/contents_layout_manager.h
[modify] https://crrev.com/8c86ba838fcfac0de766c5448a2dc5a35c28ca18/chrome/browser/ui/views/toolbar/toolbar_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment