New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864573 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 837855



Sign in to add a comment

Correctly handle issues that are deleted

Project Member Reported by liaoyuke@chromium.org, Jul 17

Issue description

Make sure when the attached issues are deleted, flake detection can re-create a new one properly and write tests to verify the behaviors.

Corner case, so marking as P2
 
Labels: flake-detection
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/df7348e19769a8611606a074dff99fbbb865bf5b

commit df7348e19769a8611606a074dff99fbbb865bf5b
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Aug 29 22:45:16 2018

[FindIt] Make Flake Detection recover from Monorail failures

Flake Detection can fail while trying to create or update issues due to
that it doesn't have permissions or the issue itself was deleted, and
in those cases, calling Monorail APIs raises a HttpError that looks
like the following:

googleapiclient.errors.HttpError: <HttpError 403 when requesting
https://monorail-staging.appspot.com/_ah/api/monorail/v1/projects/chromium/issues/621687?alt=json
returned "User is not allowed to view this  issue chromium:621687 ">

This CL makes sure that Flake Detection doesn't crash when encounter
such a failure, and will continue to create or update next issues.

Bug:  864573 ,  873190 
Change-Id: Idb3533389d75966df2af2198f2aa3711cca83f84
Reviewed-on: https://chromium-review.googlesource.com/1195942
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17298}
[modify] https://crrev.com/df7348e19769a8611606a074dff99fbbb865bf5b/appengine/findit/services/flake_detection/test/flake_report_util_test.py
[modify] https://crrev.com/df7348e19769a8611606a074dff99fbbb865bf5b/appengine/findit/services/flake_detection/flake_report_util.py

Status: Fixed (was: Assigned)

Sign in to add a comment