Endianness error in mmc Samsung hack code |
|||
Issue description0day says: tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.4 head: 1995df97b05b7bd264e82ea590c9f89a30b87b49 commit: 31ec6f00f579ee97683115c2ee20967ee3a44d71 [18/24] FROMLIST: mmc: ffu: Hack for Samsung part reproduce: # apt-get install sparse git checkout 31ec6f00f579ee97683115c2ee20967ee3a44d71 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ :::::: branch date: 2 hours ago :::::: commit date: 2 days ago >> drivers/mmc/core/ffu.c:372:21: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [assigned] [usertype] arg @@ got igned] [assigned] [usertype] arg @@ drivers/mmc/core/ffu.c:372:21: expected unsigned int [unsigned] [assigned] [usertype] arg drivers/mmc/core/ffu.c:372:21: got restricted __le32 [usertype] <noident>
,
Aug 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7bf2f3d23780680198e2012dfd9cb894759b519b commit 7bf2f3d23780680198e2012dfd9cb894759b519b Author: Gwendal Grignou <gwendal@chromium.org> Date: Sat Aug 11 11:53:01 2018 mmc: ffu: Fix endianness error Cast properly before sending data to eMMC device. BUG= chromium:864570 TEST=no warning when compiling, but tested only little endian. Change-Id: I298e13bfc9253065d6232c24c1de5488bdc03e25 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1165500 Reviewed-by: Guenter Roeck <groeck@chromium.org> [modify] https://crrev.com/7bf2f3d23780680198e2012dfd9cb894759b519b/drivers/mmc/core/ffu.c
,
Oct 3
|
|||
►
Sign in to add a comment |
|||
Comment 1 by gwendal@chromium.org
, Jul 31