New issue
Advanced search Search tips

Issue 864511 link

Starred by 1 user
Status: Verified
Owner:
stkhapugin@chromium.org
Closed: Jul 23
Cc:
justincohen@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
q4



Sign in to add a comment

Clear button “x” is not dismissed in omnibox when suggestions are scrolled up

Project Member Reported by vbarig...@chromium.org, Jul 17 
App Version: 69.0.3934.0 canary
iOS Version: 12 beta 3, 11.4.1
Device: iPhone, iPad
URL: 

Steps to reproduce:
  1.  Launch chrome canary.
  2.  Type in omnibox 
  3.  Scroll up the suggestions.
  4.  Tap on “Cancel”
  5.  Open New Tab --> Tap in Omnibox

Observed results:
Notice that Clear button “x” is displayed.

Expected results:
Clear button “x” should not be displayed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA on M67
Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M68

Link to video/image: https://drive.google.com/file/d/1sBhTna_THDfKIcK_ttVIqaYUYLpI7U6v/view?usp=sharing

Comment 1 by marq@chromium.org, Jul 17

Cc: justincohen@chromium.org
Labels: q4
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
Not a priority for M69

Comment 2 by stkhapugin@chromium.org, Jul 20

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc

commit 06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Jul 23 13:29:18 2018

Update omnibox clear button visibility on focus.

Monitor omnibox focus notification to update the clear button visibility
on focus.

Bug: 866446,  865019 ,  865013 ,  864511 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89
Reviewed-on: https://chromium-review.googlesource.com/1143860
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577161}
[modify] https://crrev.com/06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm

Comment 4 by stkhapugin@chromium.org, Jul 23

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8d73dbd650f80985ebb76c86e28af122f1901ab

commit f8d73dbd650f80985ebb76c86e28af122f1901ab
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jul 25 11:40:02 2018

Update omnibox clear button visibility on focus.

Monitor omnibox focus notification to update the clear button visibility
on focus.

Bug: 866446,  865019 ,  865013 ,  864511 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89
Reviewed-on: https://chromium-review.googlesource.com/1143860
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577161}(cherry picked from commit 06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc)
Reviewed-on: https://chromium-review.googlesource.com/1150100
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#66}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/f8d73dbd650f80985ebb76c86e28af122f1901ab/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm

Comment 6 by vbarig...@chromium.org, Jul 31

Status: Verified (was: Fixed)
Verified on chrome canary version 70.0.3509.0 on iPhone 8 plus with iOS 11.4.1, 12 beta 5, following steps mentioned in comment #0.  "x" button is not visible.  Looks good.

Comment 7 by pmadalla@chromium.org, Aug 1 

Verified the issue on the build 69.0.3497.22 beta tested on iPhone(iOS 11.4).
"x" button is not visible
►

Sign in to add a comment