New issue
Advanced search Search tips

Issue 864477 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: All/AutofillInteractiveIsolationTest.DeletingFrameUnderSuggestion/1



Sign in to add a comment

All/AutofillInteractiveIsolationTest.DeletingFrameUnderSuggestion/1 is Flaky

Project Member Reported by Findit, Jul 17

Issue description

Owner: ftirelo@chromium.org
Status: Assigned (was: Available)
On it. Will revert the cl if I can't find a quick fix in a reasonable time.
Labels: -Sheriff-Chromium
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2869e1e867c8adf275fd925a6d40cac049e8134

commit c2869e1e867c8adf275fd925a6d40cac049e8134
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Tue Jul 17 18:58:47 2018

[AF] Cleanup rows when the popup is hidden

This fixes a flaky test on ChromeOS, in which a mouse exit event can be
received by a row after the popup is hidden (in the test in case, this
happened when the frame that contained the dropdown was deleted).

The solution here consists of not giving rows direct access to the
controller; now they need to use an accessor method in the native view,
which will return nullptr after the popup is hidden.

As a safety measure, also protected other accesses to the controller,
except on CreateContent(), which is called when a row is being created,
and the controller's existence is guaranteed.

Bug:  864477 
Change-Id: I8be9be974065543ca9da6ea165365ed7777e70b7
Reviewed-on: https://chromium-review.googlesource.com/1140284
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575739}
[modify] https://crrev.com/c2869e1e867c8adf275fd925a6d40cac049e8134/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/c2869e1e867c8adf275fd925a6d40cac049e8134/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h

Status: Fixed (was: Assigned)

Sign in to add a comment