New issue
Advanced search Search tips

Issue 864475 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 717696



Sign in to add a comment

DCHECK hit in IncompatibleApplicationsHandler::GetPluralString

Project Member Reported by grt@chromium.org, Jul 17

Issue description

This one here:

  const base::Value& callback_id = args->GetList()[0];
  int num_applications = args->GetList()[1].GetInt();
  DCHECK_GT(num_applications, 0);

---

base::debug::StackTrace::StackTrace [0x68FA9996+102] (C:\src\chrome\src\base\debug\stack_trace_win.cc:286)
        base::debug::StackTrace::StackTrace [0x68FA8A3B+27] (C:\src\chrome\src\base\debug\stack_trace.cc:199)
        logging::LogMessage::~LogMessage [0x6900E664+148] (C:\src\chrome\src\base\logging.cc:593)
        settings::IncompatibleApplicationsHandler::GetPluralString [0x64E6EFCF+479] (C:\src\chrome\src\chrome\browser\ui\webui\settings\incompatible_applications_handler_win.cc:157)
        settings::IncompatibleApplicationsHandler::HandleGetSubtitlePluralString [0x64E6E735+37] (C:\src\chrome\src\chrome\browser\ui\webui\settings\incompatible_applications_handler_win.cc:134)
        base::internal::FunctorTraits<void (settings::IncompatibleApplicationsHandler::*)(const base::ListValue *) __attribute__((thiscall)),void>::Invoke<void (settings::IncompatibleApplicationsHandler::*)(const base::ListValue *) __attribute__((thiscall)),setti [0x64E713D2+66] (C:\src\chrome\src\base\bind_internal.h:507)
        base::internal::InvokeHelper<0,void>::MakeItSo<void (settings::IncompatibleApplicationsHandler::*const &)(const base::ListValue *) __attribute__((thiscall)),settings::IncompatibleApplicationsHandler *,const base::ListValue *> [0x64E712EB+107] (C:\src\chrome\src\base\bind_internal.h:607)
        base::internal::Invoker<base::internal::BindState<void (settings::IncompatibleApplicationsHandler::*)(const base::ListValue *) __attribute__((thiscall)),base::internal::UnretainedWrapper<settings::IncompatibleApplicationsHandler> >,void (const base::ListV [0x64E71261+113] (C:\src\chrome\src\base\bind_internal.h:680)
        base::internal::Invoker<base::internal::BindState<void (settings::IncompatibleApplicationsHandler::*)(const base::ListValue *) __attribute__((thiscall)),base::internal::UnretainedWrapper<settings::IncompatibleApplicationsHandler> >,void (const base::ListV [0x64E71104+84] (C:\src\chrome\src\base\bind_internal.h:662)
        base::RepeatingCallback<void (const base::ListValue *)>::Run [0x5AB91F1A+90] (C:\src\chrome\src\base\callback.h:129)
        content::WebUIImpl::ProcessWebUIMessage [0x5AB91C09+281] (C:\src\chrome\src\content\browser\webui\web_ui_impl.cc:267)
        content::WebUIImpl::OnWebUISend
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e73d601354333db371adcd3bbfa3509d7550e4

commit d9e73d601354333db371adcd3bbfa3509d7550e4
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Jul 19 22:43:00 2018

Fix DCHECK in IncompatibleApplicationsHandler::GetPluralString()

Bug:  864475 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I00a614768a2a4bdb1c077c7a6cf643fb95493be4
Reviewed-on: https://chromium-review.googlesource.com/1142041
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576669}
[modify] https://crrev.com/d9e73d601354333db371adcd3bbfa3509d7550e4/chrome/browser/resources/settings/incompatible_applications_page/incompatible_applications_page.js

Status: Fixed (was: Assigned)

Sign in to add a comment