New issue
Advanced search Search tips

Issue 864465 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 864358
Owner:
Closed: Jul 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: WindowSelectorTest.RoundedEdgeMaskVisibility



Sign in to add a comment

WindowSelectorTest.RoundedEdgeMaskVisibility is Flaky

Project Member Reported by Findit, Jul 17

Issue description

Owner: lethalantidote@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fed7475d501d0622e3604313eb93867405cba55f

commit fed7475d501d0622e3604313eb93867405cba55f
Author: Owen Min <zmin@chromium.org>
Date: Tue Jul 17 17:45:11 2018

Disable two flaky tests on ChromeOS

Disable ShelfLayoutManagerTest.FlingUpOnShelfForFullscreenAppList
Disable WindowSelectorTest.RoundedEdgeMaskVisibility

Tbr: xiyuan, xdai
Bug:  864467 ,  864465 
Change-Id: I77a0dbcddad5176575f0dc5991beb9eef8090167
Reviewed-on: https://chromium-review.googlesource.com/1140683
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575707}
[modify] https://crrev.com/fed7475d501d0622e3604313eb93867405cba55f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/fed7475d501d0622e3604313eb93867405cba55f/ash/wm/overview/window_selector_unittest.cc

Labels: -Sheriff-Chromium
Mergedinto: 864358
Status: Duplicate (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f7e41c511c5ebc86d5606614da07ff37f41d07

commit 07f7e41c511c5ebc86d5606614da07ff37f41d07
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Jul 18 00:12:18 2018

Revert "Disable two flaky tests on ChromeOS"

This reverts commit fed7475d501d0622e3604313eb93867405cba55f.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Disable two flaky tests on ChromeOS
> 
> Disable ShelfLayoutManagerTest.FlingUpOnShelfForFullscreenAppList
> Disable WindowSelectorTest.RoundedEdgeMaskVisibility
> 
> Tbr: xiyuan, xdai
> Bug:  864467 ,  864465 
> Change-Id: I77a0dbcddad5176575f0dc5991beb9eef8090167
> Reviewed-on: https://chromium-review.googlesource.com/1140683
> Reviewed-by: Owen Min <zmin@chromium.org>
> Commit-Queue: Owen Min <zmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575707}

TBR=zmin@chromium.org

Change-Id: I2aaceb5588030a1b14edf9b0c1d2da6165cbf8f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  864467 ,  864465 
Reviewed-on: https://chromium-review.googlesource.com/1140460
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575865}
[modify] https://crrev.com/07f7e41c511c5ebc86d5606614da07ff37f41d07/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/07f7e41c511c5ebc86d5606614da07ff37f41d07/ash/wm/overview/window_selector_unittest.cc

(Reason for the revert is that we believe we fixed the root cause of this in cr/864358)

Sign in to add a comment