New issue
Advanced search Search tips

Issue 864453 link

Starred by 1 user
Status: Fixed
Owner:
lucmult@chromium.org
Closed: Jul 18
Cc:
weifangsun@chromium.org
fukino@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Files app: Directory tree is not updated when "Show all Play folders" is toggled.

Project Member Reported by fukino@chromium.org, Jul 17 
Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Enable "Show Android files in Files app" flag in chrome://flags
(2) Observe that "Play files" root has Movies, Pictures, and Music.
(3) From gear menu on top-right corner, click "Show all Play folders".
(4) Observe the directory tree.

What is the expected result?
"Play files" has other folders like Alarms, DCIM, etc...

What happens instead?
Although the file list on right hand side has those folders, directory tree doesn't have it.


If we disable "My files" by enabling #disable-my-files-navigation, this issue does not reproduce.
I guess we miss something when introducing "My files".

Comment 1 by lucmult@chromium.org, Jul 18

Status: Started (was: Assigned)

Comment 2 by lucmult@chromium.org, Jul 18 

Thanks for reporting Fukino-san.

Ok, I got the error is that "My files" isn't propagating the update recursively to its children.

I managed to reproduce with Downloads + a hidden folder and the option "Show hidden files", so I'm working to write a test for this condition.

Comment 3 by lucmult@chromium.org, Jul 18 

CL out for review.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d53f818f8855d0fc70559e4c1d99a0134e2eb34b

commit d53f818f8855d0fc70559e4c1d99a0134e2eb34b
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Wed Jul 18 06:29:55 2018

Fix My files not updating directory tree recursively

Fix issue where My files doesn't propagate updates in the directory tree
when folders are displayed or hidden.

Test: Integration test and checked that it fails without the fix.
Bug:  864453 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2e7cee1b0d34bccb7d417d650ede04b9bd5aa6fd
Reviewed-on: https://chromium-review.googlesource.com/1141454
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575958}
[modify] https://crrev.com/d53f818f8855d0fc70559e4c1d99a0134e2eb34b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/d53f818f8855d0fc70559e4c1d99a0134e2eb34b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/d53f818f8855d0fc70559e4c1d99a0134e2eb34b/ui/file_manager/integration_tests/file_manager/my_files.js

Comment 6 by lucmult@chromium.org, Jul 18

Status: Fixed (was: Started)
The patch above fixes it.
►

Sign in to add a comment