New issue
Advanced search Search tips

Issue 864452 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Print Preview] Unable to keep focus on 'Fit to page' checkbox via keyboard.

Reported by dchau...@etouch.net, Jul 17

Issue description

Chrome Version: 69.0.3494.0 (Official Build) Revision	e91414c45bcdc6397f1a38faa0c826fbc47cd772-refs/branch-heads/3494@{#1} 32/64-bit.
OS: Mac(10.12.6, 10.13.1, 10.13.6, 10.14), Windows(7,8,8.1,10) and Linux(14.04).

Pre-condition: Enabled 'Enable new Print Preview UI' flag from chrome://flags

Test URL: https://www.nobelprize.org/nobel_prizes/economic-sciences/laureates/2005/press-he.pdf

What steps will reproduce the problem?
1. Launch Chrome and navigate to above Test URL or any PDF page.
2. Give print command and click on 'More settings' option.
3. Now press 'Tab' key from keyboard and observe the focus.

Actual: Blue focus ring doesn't traverse through 'Fit to page' checkbox.
Expected: Blue focus ring should traverse through 'Fit to page' checkbox.

This is a non-regression issue, seen from M-64 series.

NOTE: This issue is also reproducible on Stable #67.0.3396.99, Beta #68.0.3440.59 & Dev #69.0.3486.0

Kindly review the attached screen-cast for reference.

Thank you.

 
Actual_With_Flag.mp4
1.2 MB View Download
Expected_Without_Flag.mp4
921 KB View Download
Status: Untriaged (was: Unconfirmed)
Owner: rbpotter@chromium.org
Update:
This issue is observed from M-64 series as 'Enable new Print Preview UI' flag is introduced from build #64.0.3250.0
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57186f5dff9d6a5215f6604ba4c897f919039ff2

commit 57186f5dff9d6a5215f6604ba4c897f919039ff2
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jul 18 07:16:25 2018

Print Preview Componentization: Put fit to page in correct tab order

Use tabindex=1 so it is focused before the scaling number input. When
the checkbox appears it is above the number input so should be focused
first.

Bug:  864452 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I42d7841e89f9bd6098f9ff8a9ff4934270c391c9
Reviewed-on: https://chromium-review.googlesource.com/1140495
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575963}
[modify] https://crrev.com/57186f5dff9d6a5215f6604ba4c897f919039ff2/chrome/browser/resources/print_preview/new/scaling_settings.html

Labels: TE-Verified-69.0.3496.0 TE-Verified-M69
Update:

Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.6, 10.14), Windows(7,8,8.1,10) and Linux(14.04) machines using latest canary #69.0.3496.0 and issue is fixed. Hence adding TE-Verified labels.

please refer below attached screen-cast for reference.

Thank You.
Fixed_behavior.mp4
1.0 MB View Download
Status: Fixed (was: Untriaged)

Sign in to add a comment