New issue
Advanced search Search tips

Issue 864450 link

Starred by 1 user
Status: Fixed
Owner:
w...@chromium.org
Closed: Jul 30
Cc:
sergeyu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug-Regression



Sign in to add a comment

UDPSocketTest.JoinMulticastGroup fails under Fuchsia

Project Member Reported by w...@chromium.org, Jul 17 
Since migrating to the network-index-based version of the API, this test always fails (e.g. see run https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-rel/543) with:

[ RUN      ] UDPSocketTest.JoinMulticastGroup
../../net/socket/udp_socket_unittest.cc:647: Failure
Value of: socket.JoinGroup(group_ip)
Expected: net::OK
  Actual: -109, net::ERR_ADDRESS_UNREACHABLE
Stack trace:
bt#00: pc 0x1579d430e426 (app:/pkg/bin/app,0x2825426)
bt#01: pc 0x1579d430ddcb (app:/pkg/bin/app,0x2824dcb)
bt#02: pc 0x1579d394d7c5 (app:/pkg/bin/app,0x1e647c5)
bt#03: end
../../net/socket/udp_socket_unittest.cc:650: Failure
Value of: socket.LeaveGroup(group_ip)
Expected: net::OK
  Actual: -109, net::ERR_ADDRESS_UNREACHABLE
Stack trace:
bt#00: pc 0x1579d430e426 (app:/pkg/bin/app,0x2825426)
bt#01: pc 0x1579d430ddcb (app:/pkg/bin/app,0x2824dcb)
bt#02: pc 0x1579d394da30 (app:/pkg/bin/app,0x1e64a30)
bt#03: end
[  FAILED  ] UDPSocketTest.JoinMulticastGroup (26 ms)

ERR_ADDRESS_UNREACHABLE appears to be the catch-all return-code used for both bogus interface Ids, bogus or unreachable target addresses, etc, so this is likely a bug in the actual network stack.

Comment 1 by w...@chromium.org, Jul 17 

Note that sergeyu@ has landed fixes to Fuchsia's netstack which we are unable to verify due to the Fuchsia SDK roll being blocked on code-review (see https://chromium-review.googlesource.com/c/chromium/src/+/1137750).

Comment 2 by w...@chromium.org, Jul 27

Labels: -M-69 M-70
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d21eb85bd5326d1e5f6a58ef0ec409baab00b40d

commit d21eb85bd5326d1e5f6a58ef0ec409baab00b40d
Author: Wez <wez@chromium.org>
Date: Mon Jul 30 22:48:04 2018

Migrate UDPSocket::LeaveGroup IPv4 case to include interface Id.

LeaveGroup() previously used ip_mreq, which does not allow the interface
to which the operation applies to be specified by Id. Since no interface
IP address is specified in the call, it fails if the network stack
expects the interface to be explicitly specified (i.e. under Fuchsia).

Bug:  864450 
Change-Id: Idff67518387d80c6c91f96bfd774db4a11a310f8
Reviewed-on: https://chromium-review.googlesource.com/1152903
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579212}
[modify] https://crrev.com/d21eb85bd5326d1e5f6a58ef0ec409baab00b40d/net/socket/udp_socket_posix.cc

Comment 4 by w...@chromium.org, Jul 30

Status: Fixed (was: Started)
►

Sign in to add a comment