New issue
Advanced search Search tips

Issue 864437 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

crash in vm_tools::vsh::DataMessage::set_data

Reported by andy.boy...@gmail.com, Jul 17

Issue description

IMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it.


Chrome Version: 69.0.3486.0
Operating System: Linux 4.4.139-14472-g6853af561948

Can you reproduce this crash?
Yes

What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?)
1. Visit https://www.amazon.com/dp/B07BR3F9N6 in an Incognito window
2. Switch to Incognito window, scroll around
3. Press Ctrl-W on the keyboard to close window/tab and observe the screen go black as Chrome recovers from crash.

****DO NOT CHANGE BELOW THIS LINE****
Crash ID: crash/74657901f2ae6916

 
Labels: OS-Chrome
As per the above provided crash id, issue seems to be specific to Chrome OS hence adding the same OS to proceed further.
Thanks..!
Components: OS>Systems>Containers
Description: Show this description
Cc: smbar...@chromium.org
Labels: -Restrict-View-EditIssue Pri-2 Type-Bug
Summary: crash in vm_tools::vsh::DataMessage::set_data (was: ChromeOS dev channel crash when closing incognito window)
this was reported against R69 a while back.  we should check crash rates for this signature to see if it's gone down in newer versions in case it's already been fixed.
Labels: Proj-Containers M-72
Owner: smbar...@chromium.org
Status: Started (was: Unconfirmed)
This is a bad codepath in vsh, which I'll fix with https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1313660
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9b00411b10266315f10b7e76d4285c308db4c7fc

commit 9b00411b10266315f10b7e76d4285c308db4c7fc
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Nov 02 21:50:46 2018

vm_tools: vsh: fix crash when stdin has an error

After calling Shutdown(), return from HandleStdinReadable early
to avoid attempting to send a data message to the server.

BUG= chromium:864437 
TEST=none

Change-Id: Ied5beda68b5574ccda8d324271d54c3c1bacd49f
Reviewed-on: https://chromium-review.googlesource.com/1313660
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/9b00411b10266315f10b7e76d4285c308db4c7fc/vm_tools/vsh/vsh_client.cc

Status: Verified (was: Started)

Sign in to add a comment