Heap Compaction for incremental marking GC |
||||||
Issue descriptionIn BlinkGC, current heap compactor isn't working for incremental marking GC. So, we implement this, and expect that heap compactor leads to reduce memory usage.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2badd9d418c2617c74d083b0e4982cd2778b6684 commit 2badd9d418c2617c74d083b0e4982cd2778b6684 Author: Haruka Matsumura <harukamt@google.com> Date: Thu Jul 26 04:01:54 2018 Revert "Oilpan: Change slots registration in HeapCompaction" This reverts commit 49874bf7b6420872744e1e8e7a336ae245993d18. Reason for revert: caused a crash crbug.com/867359 Original change's description: > Oilpan: Change slots registration in HeapCompaction > > This CL changes the system of slots registration in HeapCompaction. > As preparing for HeapCompaction with IncrementalMarking, we change a timing of the registration on HashMap that related to slots, from during tracing to during atomic pause. > So, we add HashSet that registeres traced slots. > > Bug: 864425 > Change-Id: Ia63c36abbf160dfea115ebd6c6953c499d895770 > Reviewed-on: https://chromium-review.googlesource.com/1145144 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Haruka Matsumura <harukamt@google.com> > Cr-Commit-Position: refs/heads/master@{#577469} TBR=tasak@google.com,haraken@chromium.org,keishi@chromium.org,harukamt@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864425 Change-Id: Ia60c4361ef2a50c5451e3696b41020ce018e7e7a Reviewed-on: https://chromium-review.googlesource.com/1150007 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Haruka Matsumura <harukamt@google.com> Cr-Commit-Position: refs/heads/master@{#578188} [modify] https://crrev.com/2badd9d418c2617c74d083b0e4982cd2778b6684/third_party/blink/renderer/platform/heap/heap_compact.cc [modify] https://crrev.com/2badd9d418c2617c74d083b0e4982cd2778b6684/third_party/blink/renderer/platform/heap/heap_compact.h
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/402792187b8fba31b2a8c3eaecc2d90ce8a3f786 commit 402792187b8fba31b2a8c3eaecc2d90ce8a3f786 Author: Haruka Matsumura <harukamt@google.com> Date: Mon Jul 30 13:16:46 2018 [Reland] Oilpan: Change slots registration in HeapCompaction This CL changes the system of slots registration in HeapCompaction. As preparing for HeapCompaction with IncrementalMarking, we change a timing of the registration on HashMap that related to slots, from during tracing to during atomic pause. So, we add HashSet that registeres traced slots. Previous commit caused a crash in heap_compact.cc:Add(slot), because it didn't check whether the reference is nullptr. So, we fixed it and we modified null check of backing_store from TraceBackingStoreStrongly() to VisiBackingStoreStorngly. Bug: 864425 Change-Id: I5e7edec41918b4058b9763b7ce60eadf50d43311 Reviewed-on: https://chromium-review.googlesource.com/1151043 Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Haruka Matsumura <harukamt@google.com> Cr-Commit-Position: refs/heads/master@{#579024} [modify] https://crrev.com/402792187b8fba31b2a8c3eaecc2d90ce8a3f786/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/402792187b8fba31b2a8c3eaecc2d90ce8a3f786/third_party/blink/renderer/platform/heap/heap_compact.cc [modify] https://crrev.com/402792187b8fba31b2a8c3eaecc2d90ce8a3f786/third_party/blink/renderer/platform/heap/heap_compact.h [modify] https://crrev.com/402792187b8fba31b2a8c3eaecc2d90ce8a3f786/third_party/blink/renderer/platform/heap/marking_visitor.h [modify] https://crrev.com/402792187b8fba31b2a8c3eaecc2d90ce8a3f786/third_party/blink/renderer/platform/heap/visitor.h
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ecc5f22ddedb7f12824106484f356942c54e9fe commit 5ecc5f22ddedb7f12824106484f356942c54e9fe Author: Haruka Matsumura <harukamt@google.com> Date: Wed Aug 01 04:02:05 2018 Oilpan: Fix DCHECK for fixups_ in HeapCompaction This CL changes DCHECK for fixups_ to Fixups(). They are guaranteed that AddCompactingPage() and RegisterMovingObjectCallback() are called before these method. But we collect also HeapCollections that have no buffer so it is not guaranteed. Bug: 864425 Change-Id: Id28cc98f060f4125bca04664a9e8416f9cf97fcc Reviewed-on: https://chromium-review.googlesource.com/1156527 Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Haruka Matsumura <harukamt@google.com> Cr-Commit-Position: refs/heads/master@{#579692} [modify] https://crrev.com/5ecc5f22ddedb7f12824106484f356942c54e9fe/third_party/blink/renderer/platform/heap/heap_compact.cc
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43607a09825fdb040314140ab3e59e0303e0a3ce commit 43607a09825fdb040314140ab3e59e0303e0a3ce Author: Haruka Matsumura <harukamt@google.com> Date: Fri Aug 10 09:50:34 2018 Oilpan: Modify collected traced_slot_ in HeapCompaction This CL modifies collected traced_slot_ in HeapCompaction. In atomic pause GC world, slots that has nullptr references and only has an inline buffer are not collected by traced_slot_ because such HeapCollections are ealy returned in Trace method. However, In incremental GC, we want to collect such slots because they might have references to OutOfLineBuffer after tracing. So, we modified to collect all slots. Bug: 864425 Change-Id: I08d94ae86eb33973addcd2f535a003d29c9eeb3b Reviewed-on: https://chromium-review.googlesource.com/1156112 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582102} [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/bindings/core/v8/script_wrappable_visitor_test.cc [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.cc [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/platform/heap/heap_compact.cc [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/platform/heap/marking_visitor.h [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/platform/heap/visitor.h [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/platform/wtf/deque.h [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/platform/wtf/hash_table.h [modify] https://crrev.com/43607a09825fdb040314140ab3e59e0303e0a3ce/third_party/blink/renderer/platform/wtf/vector.h
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9655730fb2e2ce54d77d926969bcfdd4d5c7623f commit 9655730fb2e2ce54d77d926969bcfdd4d5c7623f Author: Haruka Matsumura <harukamt@google.com> Date: Fri Aug 10 10:08:56 2018 Oilpan: Change callback registration in HeapCompaction This CL changes the system of callback registration to slot-based as with references. Anytime HeapLinkedHashSet rehashes and impl_.table_ changes while incremental marking is in progress, is when the callback won't be called. So as preparing for HeapCompaction with IncrementalMarking, we change the key of the registration on HashMap from references(buffer address) to slots. Bug: 864425 Change-Id: I5af93f1c56d0a76952e3347c4f3f1ba4f271047b Reviewed-on: https://chromium-review.googlesource.com/1164881 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582104} [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.h [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/heap.h [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/heap_allocator.h [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/heap_compact.cc [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/heap_compact.h [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/incremental_marking_test.cc [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/marking_verifier.h [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/marking_visitor.cc [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/marking_visitor.h [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/heap/visitor.h [modify] https://crrev.com/9655730fb2e2ce54d77d926969bcfdd4d5c7623f/third_party/blink/renderer/platform/wtf/linked_hash_set.h
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f27b0a7411bb51ac7cb2bbe75799cb5870170743 commit f27b0a7411bb51ac7cb2bbe75799cb5870170743 Author: Haruka Matsumura <harukamt@google.com> Date: Fri Aug 10 13:53:02 2018 Oilpan: Implement slot remove method for HeapCollection This CL adds will remove slots for HeapCollections that are destrcuted by mutator when Incremental Marking. When each HeapCollection are destructed, RemoveSlot is called and destructed slots are removed from the registry in HeapCompact. Bug: 864425 Change-Id: I09e7fcbe22cfd97fe5108249aed602de67c97066 Reviewed-on: https://chromium-review.googlesource.com/1150003 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582142} [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/heap/heap_compact.cc [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/heap/heap_compact.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/heap/persistent.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/wtf/deque.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/wtf/hash_counted_set.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/wtf/hash_map.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/wtf/hash_set.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/wtf/hash_table.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/wtf/linked_hash_set.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/wtf/list_hash_set.h [modify] https://crrev.com/f27b0a7411bb51ac7cb2bbe75799cb5870170743/third_party/blink/renderer/platform/wtf/vector.h
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0787194dfc3ab53eca729e1f5bc326661a4a43c3 commit 0787194dfc3ab53eca729e1f5bc326661a4a43c3 Author: Keishi Hattori <keishi@chromium.org> Date: Fri Aug 10 20:21:08 2018 Oilpan: Add Unit Tests in HeapCompaction for IncrementalMarking This CLs added 3 unit tests in HeapCompaction for IncrementalMarking. One of tests checks that slots is collected if the slot content is nullptr of inline buffer. Another case checks whether compaction is correctly working if collected slot is dropped references. Moreover, we check whether compaction is correctly working if collected slot is destructed by mutator. Bug: 864425 Change-Id: I3038c9a6e2607f3ed81a5f438a1ab415fa96df9a Reviewed-on: https://chromium-review.googlesource.com/1152750 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582313} [modify] https://crrev.com/0787194dfc3ab53eca729e1f5bc326661a4a43c3/third_party/blink/renderer/platform/heap/heap_compact.cc [modify] https://crrev.com/0787194dfc3ab53eca729e1f5bc326661a4a43c3/third_party/blink/renderer/platform/heap/heap_compact.h [modify] https://crrev.com/0787194dfc3ab53eca729e1f5bc326661a4a43c3/third_party/blink/renderer/platform/heap/incremental_marking_test.cc
,
Sep 20
iOS does not use Blink
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10a10dd9fde23fa0f038c83fa9940ea69afcae2a commit 10a10dd9fde23fa0f038c83fa9940ea69afcae2a Author: Keishi Hattori <keishi@chromium.org> Date: Mon Oct 29 13:19:57 2018 Oilpan: Enable HeapCompaction for incremental marking Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. Bug: 864425 Change-Id: I1fb04d7c501a8519e106237946f86f52eb7ce8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1297782 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603477} [modify] https://crrev.com/10a10dd9fde23fa0f038c83fa9940ea69afcae2a/third_party/blink/renderer/platform/heap/heap_compact.cc
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ce72e129d923a9f4a6ff0eae3c599b25fdb8d36 commit 0ce72e129d923a9f4a6ff0eae3c599b25fdb8d36 Author: Yuly Novikov <ynovikov@chromium.org> Date: Mon Oct 29 18:33:30 2018 Revert "Oilpan: Enable HeapCompaction for incremental marking" This reverts commit 10a10dd9fde23fa0f038c83fa9940ea69afcae2a. Reason for revert: Suspected for flaky crashes affecting Chromium CQ. Original change's description: > Oilpan: Enable HeapCompaction for incremental marking > > Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. > > Bug: 864425 > > Change-Id: I1fb04d7c501a8519e106237946f86f52eb7ce8f8 > Reviewed-on: https://chromium-review.googlesource.com/c/1297782 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603477} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org Change-Id: Ie72a2eb04571945b3515ee7374a75a1ab87275c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864425, 899809 Reviewed-on: https://chromium-review.googlesource.com/c/1305833 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603573} [modify] https://crrev.com/0ce72e129d923a9f4a6ff0eae3c599b25fdb8d36/third_party/blink/renderer/platform/heap/heap_compact.cc
,
Oct 29
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7dbf77305b6467e1a2b905f72720398a20faa1e commit d7dbf77305b6467e1a2b905f72720398a20faa1e Author: Keishi Hattori <keishi@chromium.org> Date: Fri Nov 02 10:06:11 2018 Oilpan: Backing slots are not registered for some weak HashTables Weak HashTable's backing slots went unregistered, when it gains a backing after it has been traced. We need to register the backing slot from HashTable::Trace even when there is no backing yet. Bug: 864425 Change-Id: I09a0f6031e457242a4374429dde5360777bebc21 Reviewed-on: https://chromium-review.googlesource.com/c/1312189 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604875} [modify] https://crrev.com/d7dbf77305b6467e1a2b905f72720398a20faa1e/third_party/blink/renderer/platform/heap/heap_compact.cc [modify] https://crrev.com/d7dbf77305b6467e1a2b905f72720398a20faa1e/third_party/blink/renderer/platform/heap/heap_compact.h [modify] https://crrev.com/d7dbf77305b6467e1a2b905f72720398a20faa1e/third_party/blink/renderer/platform/heap/incremental_marking_test.cc [modify] https://crrev.com/d7dbf77305b6467e1a2b905f72720398a20faa1e/third_party/blink/renderer/platform/heap/marking_visitor.h [modify] https://crrev.com/d7dbf77305b6467e1a2b905f72720398a20faa1e/third_party/blink/renderer/platform/heap/visitor.h
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cc1550c36085cb1afa75b0f5b159af15f8d997d commit 2cc1550c36085cb1afa75b0f5b159af15f8d997d Author: Keishi Hattori <keishi@chromium.org> Date: Tue Nov 06 06:07:25 2018 [Reland] Oilpan: Enable HeapCompaction for incremental marking Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. Bug: 864425 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603477} Change-Id: I506868b5ea224714491fb4dfd9403e5311550255 Reviewed-on: https://chromium-review.googlesource.com/c/1316954 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605608} [modify] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/blink/renderer/platform/heap/heap_compact.cc
,
Nov 8
,
Nov 8
,
Nov 8
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8be7c692e1956a9a67292a735811503f52396326 commit 8be7c692e1956a9a67292a735811503f52396326 Author: Keishi Hattori <keishi@chromium.org> Date: Thu Nov 08 13:47:41 2018 Revert "[Reland] Oilpan: Enable HeapCompaction for incremental marking" This reverts commit 2cc1550c36085cb1afa75b0f5b159af15f8d997d. Reason for revert: Caused crashes crbug.com/902832 crbug.com/902848 Original change's description: > [Reland] Oilpan: Enable HeapCompaction for incremental marking > > Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. > > Bug: 864425 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#603477} > Change-Id: I506868b5ea224714491fb4dfd9403e5311550255 > Reviewed-on: https://chromium-review.googlesource.com/c/1316954 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605608} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864425 Change-Id: I864a985719c1c12bf4b56f05d228c6ff8450ef5f Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1326341 Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606449} [modify] https://crrev.com/8be7c692e1956a9a67292a735811503f52396326/third_party/blink/renderer/platform/heap/heap_compact.cc
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b77e6c51c6ac67a51dd55731d220f658bc96f7cc commit b77e6c51c6ac67a51dd55731d220f658bc96f7cc Author: Keishi Hattori <keishi@chromium.org> Date: Tue Dec 18 12:02:22 2018 Oilpan: Enable HeapCompaction for incremental marking Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. Bug: 864425 Change-Id: I397aefd20a3bde8e6cf5140067f2e1a70ff46811 Reviewed-on: https://chromium-review.googlesource.com/c/1381321 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#617450} [modify] https://crrev.com/b77e6c51c6ac67a51dd55731d220f658bc96f7cc/third_party/blink/renderer/platform/heap/heap_compact.cc
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f22a7130bbf92e12a84063cb662dcd704f44fc2d commit f22a7130bbf92e12a84063cb662dcd704f44fc2d Author: Keishi Hattori <keishi@chromium.org> Date: Thu Dec 20 16:41:47 2018 Revert "Oilpan: Enable HeapCompaction for incremental marking" This reverts commit b77e6c51c6ac67a51dd55731d220f658bc96f7cc. Reason for revert: Caused crashes crbug.com/902832 crbug.com/902848 Original change's description: > Oilpan: Enable HeapCompaction for incremental marking > > Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. > > Bug: 864425 > Change-Id: I397aefd20a3bde8e6cf5140067f2e1a70ff46811 > Reviewed-on: https://chromium-review.googlesource.com/c/1381321 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617450} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864425 Change-Id: I54e486f784a6f0b8eb7bbda80a58b52661fa8501 Reviewed-on: https://chromium-review.googlesource.com/c/1386764 Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#618243} [modify] https://crrev.com/f22a7130bbf92e12a84063cb662dcd704f44fc2d/third_party/blink/renderer/platform/heap/heap_compact.cc
,
Dec 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10c893e09636ff812be6a89c526afe55ef2d2551 commit 10c893e09636ff812be6a89c526afe55ef2d2551 Author: Keishi Hattori <keishi@chromium.org> Date: Wed Dec 26 08:29:18 2018 Oilpan: Enable HeapCompaction for incremental marking Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. Bug: 864425 Change-Id: I3ade262c7dedbc19a4ab76ef8b539bced6ff9d4d Reviewed-on: https://chromium-review.googlesource.com/c/1390876 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#618913} [modify] https://crrev.com/10c893e09636ff812be6a89c526afe55ef2d2551/third_party/blink/renderer/platform/heap/heap_compact.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 24