Issue metadata
Sign in to add a comment
|
run_web_tests.py --reset-results doesn't create -expected.txt files for testharness.js tests |
||||||||||||||||||||||
Issue descriptionSome time in the past, --reset-results would create the necessary -expected.txt files for testharness.js tests. This is no longer the case, but it does still work for other tests. Two tests to try it with: editing/execCommand/insert-paragraph-into-table.html (testharness.js) editing/execCommand/indent-div-inside-list.html (testRunner.dumpAsText()) Steps to repro: ``` rm editing/execCommand/insert-paragraph-into-table-expected.txt editing/execCommand/indent-div-inside-list-expected.txt third_party/blink/tools/run_web_tests.py --target=Default --reset-results editing/execCommand/insert-paragraph-into-table.html editing/execCommand/indent-div-inside-list.html ``` The output has: Writing new expected result "editing/execCommand/indent-div-inside-list-expected.txt" But "editing/execCommand/insert-paragraph-into-table-expected.txt" is still not deleted. robertma@, any idea what might cause this? I think someone has mentioned it to me before, and I noticed it myself today.
,
Aug 17
Confirmed. And yes it's a regression. CL up: https://chromium-review.googlesource.com/c/chromium/src/+/1179363
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b460e2f57e2a1c2018fc1c94994bfd4d4cfb926 commit 0b460e2f57e2a1c2018fc1c94994bfd4d4cfb926 Author: Robert Ma <robertma@chromium.org> Date: Fri Aug 17 15:10:21 2018 [run_web_tests] Fix --reset-results for testharness.js tests In https://crrev.com/c/833751 we stopped to create new baselines for testharness.js tests without existing baselines. This behaviour is in fact undesired: if a testharness.js test used to pass (and hence didn't have a baseline), we'd like to be able to create a new baseline for it using --reset-results if it starts to fail. The comment is improved so hopefully that is clear enough. Bug: 864410 Change-Id: I9b21a6e8d909585f8eb44e53dd90b488f383ea1a Reviewed-on: https://chromium-review.googlesource.com/1179363 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584069} [modify] https://crrev.com/0b460e2f57e2a1c2018fc1c94994bfd4d4cfb926/third_party/blink/tools/blinkpy/web_tests/controllers/single_test_runner.py [modify] https://crrev.com/0b460e2f57e2a1c2018fc1c94994bfd4d4cfb926/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
,
Aug 17
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by foolip@chromium.org
, Jul 18