New issue
Advanced search Search tips

Issue 864405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

editing/.../offset-from-point-complex-scripts.html in webkit_layout_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 17

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mastiz@google.com

editing/.../offset-from-point-complex-scripts.html in webkit_layout_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Builders failed on: 
- Mac10.13 Tests (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29


 
Cc: fs...@chromium.org
Seems due to https://chromium-review.googlesource.com/1085554, which I'm reluctant to revert.
Owner: mastiz@chromium.org
Status: Started (was: Available)
Actually going ahead with the revert.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b

commit 29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b
Author: Mikel Astiz <mastiz@chromium.org>
Date: Tue Jul 17 09:07:01 2018

Revert "Add support for mid ligature positions"

This reverts commit 1e3235b397f5fd7e875ae1548ee2ce385cb22af8.

Reason for revert: suspect for breaking webkit_layout_tests on
Mac, e.g. test offset-from-point-complex-scripts.html.

Bug:  864405 

Original change's description:
> Add support for mid ligature positions
> 
> Makes XPositionForOffset and CharacterIndexForPosition support
> return results inside a ligature glyph (while still not breaking ZWJs)
> by using a character-based TextBreakIterator inside glyphs.
> 
> Bug:  473476 
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I723cc8ba081958ff2d470d3e73ead6cbe327cf60
> Reviewed-on: https://chromium-review.googlesource.com/1085554
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Fernando Serboncini <fserb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575496}

TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org,fserb@chromium.org

Change-Id: Id20c3aca9139d65e4187009e7ef7b45f87cceb5e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  473476 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1140073
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575587}
[add] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/image-selection-highlight-expected.txt
[add] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection/atsui-partial-selection-expected.txt
[add] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection/emphasis-expected.txt
[add] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection/justified-selection-expected.txt
[add] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection/selection-multiple-runs-expected.txt
[add] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection/should-use-atsui-expected.txt
[add] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/japanese-rl-selection-expected.txt
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/modify-up-on-rtl-wrapping-text-expected.txt
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/offset-from-point-complex-scripts-expected.txt
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/color-emoji-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/complex-preferred-logical-widths-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/drawBidiText-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/drawBidiText-expected.txt
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/emoticons-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/emphasis-complex-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/fallback-traits-fixup-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/font-fallback-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/font-fallback-expected.txt
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/international/bidi-listbox-atsui-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/international/bidi-listbox-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/international/hindi-spacing-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/international/lang-glyph-cache-separation-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/justify-ideograph-complex-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/justify-ideograph-simple-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/justify-ideograph-vertical-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/mac-system-ui-trak-expected.txt
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/midword-break-before-surrogate-pair-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/selection/flexbox-selection-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/selection/flexbox-selection-expected.txt
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/selection/flexbox-selection-nested-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/selection/flexbox-selection-nested-expected.txt
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/selection/khmer-selection-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/selection/mixed-directionality-selection-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/selection/selection-painted-separately-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/textIteratorNilRenderer-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/textIteratorNilRenderer-expected.txt
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/unicode-fallback-font-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/unicode-fallback-font-expected.txt
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/updateNewFont-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/updateNewFont-expected.txt
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-mac10.12/editing/selection/modify-up-on-rtl-wrapping-text-expected.txt
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-mac10.12/editing/selection/offset-from-point-complex-scripts-expected.txt
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/text/selection/selection-painted-separately-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/modify-up-on-rtl-wrapping-text-expected.txt
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/offset-from-point-complex-scripts-expected.txt
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/selection/atsui-partial-selection-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/selection/emphasis-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/selection/justified-selection-at-edge-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/selection/justified-selection-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/selection/selection-multiple-runs-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/selection/selection-painted-separately-expected.png
[rename] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selection-within-composited-scroller-expected.txt
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/win7/editing/selection/replaced-boundaries-1-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/win7/paint/selection/atsui-partial-selection-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/win7/paint/selection/emphasis-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/win7/paint/selection/justified-selection-at-edge-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/win7/paint/selection/justified-selection-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/win7/paint/selection/selection-multiple-runs-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/win7/paint/selection/text-selection-inline-block-expected.png
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/WebKit/LayoutTests/platform/win7/paint/selection/text-selection-inline-block-rtl-expected.png
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/core/layout/layout_text.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/core/layout/line/breaking_context_inline_headers.h
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/core/layout/line/inline_text_box.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/core/layout/line/inline_text_box.h
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/core/layout/ng/inline/ng_physical_text_fragment.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/core/layout/svg/line/svg_inline_text_box.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/core/layout/svg/line/svg_inline_text_box.h
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/exported/web_font.cc
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/blink/renderer/platform/fonts/cursor_position_test.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/font.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/font.h
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/caching_word_shaper.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/caching_word_shaper.h
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/harf_buzz_shaper.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/harf_buzz_shaper_test.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/shape_result.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/shape_result.h
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/shape_result_buffer.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/shape_result_buffer.h
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/fonts/shaping/shape_result_inline_headers.h
[delete] https://crrev.com/70ef7183f41258454d61368d7f850bb912679d6e/third_party/blink/renderer/platform/testing/shape_result_perf_test.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/text/text_break_iterator.cc
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/text/text_break_iterator.h
[modify] https://crrev.com/29a25b6ce1f99ce6e74d8fe2e87aa491f11f367b/third_party/blink/renderer/platform/text/text_break_iterator_test.cc

Status: Fixed (was: Started)

Sign in to add a comment