New issue
Advanced search Search tips

Issue 864402 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

virtual/.../flexbox-with-overflow-auto-child-crash.html in site_per_process_webkit_layout_tests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 17

Issue description

Owner: mastiz@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43df04fe7fe11a69605cfa669226ae74b91c41c2

commit 43df04fe7fe11a69605cfa669226ae74b91c41c2
Author: Mikel Astiz <mastiz@chromium.org>
Date: Tue Jul 17 08:11:30 2018

Revert "[layoutng] Use the correct layout algorithm to compute min/max sizes"

This reverts commit 02a52f516f88d6a2046d38c73957af363f35691c.

Reason for revert: suspect of causing test failures on multiple
bots for test flexbox-with-overflow-auto-child-crash.html.

Bug:  864402 

Original change's description:
> [layoutng] Use the correct layout algorithm to compute min/max sizes
> 
> This also required adding a check in NGBlockNode::ComputeMinMaxSize
> for whether we are inside of PerformLayout -- on Mac, we can
> compute preferred sizes outside of layout; however, we can't do
> actual layout in that case, so we have to fallback to legacy
> min/max size in this case (c.f. RenderViewImpl::CheckPreferredSize())
> 
> Bug: 635619
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Change-Id: I0caf0c6c79264074ccaf9f45b83a420950dab715
> Reviewed-on: https://chromium-review.googlesource.com/1131562
> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575545}

TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org

Change-Id: I02d8cbfe883bafb2a3780ec46bd11b9e786678f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1140033
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575576}
[modify] https://crrev.com/43df04fe7fe11a69605cfa669226ae74b91c41c2/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/0b46e1db3d88b762411614d6ae7bbe4f1d5cd6e0/third_party/WebKit/LayoutTests/fast/multicol/intrinsic-width-expected.html
[delete] https://crrev.com/0b46e1db3d88b762411614d6ae7bbe4f1d5cd6e0/third_party/WebKit/LayoutTests/fast/multicol/intrinsic-width.html
[modify] https://crrev.com/43df04fe7fe11a69605cfa669226ae74b91c41c2/third_party/blink/renderer/core/layout/ng/ng_block_node.cc
[modify] https://crrev.com/43df04fe7fe11a69605cfa669226ae74b91c41c2/third_party/blink/renderer/core/layout/ng/ng_block_node.h

Status: Fixed (was: Started)

Sign in to add a comment