New issue
Advanced search Search tips

Issue 864399 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 864358
Owner:
Closed: Jul 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webkit_layout_tests failing on multiple MSAN bots

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 17

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mastiz@google.com

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty MSAN

Builders failed on: 
- WebKit Linux Trusty MSAN: 
  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d415625cfc8e9befba07b7f107c634f42d0fb44

commit 8d415625cfc8e9befba07b7f107c634f42d0fb44
Author: Mikel Astiz <mastiz@chromium.org>
Date: Tue Jul 17 07:51:02 2018

Revert "Prevents compositor frames from being sent when SurfaceLayer is not visible."

This reverts commit 6be34509e3e7f532e2ebf4f8390be6b094bd819d.

Reason for revert: suspect for webkit_layout_tests failures on MSAN,
complaining about use-of-uninitialized-value, e.g.:
https://chromium-swarm.appspot.com/task?id=3ebe376bfe81a410&refresh=10&show_raw=1 

Bug:  864399 

Original change's description:
> Prevents compositor frames from being sent when SurfaceLayer is not visible.
> 
> This CL is 3/3 in effort to fix the regressions caused by sending
> unneeded compositor frames.
> 
> This CL provides a signal from the SurfaceLayerImpl to the VideoFrameSubmitter
> to prevent compositor frames from being sent at undesired times (occlusion, not
> being added into the layer tree).
> 
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I428860047eaf4c50abc2e662914a643158f1276b
> Reviewed-on: https://chromium-review.googlesource.com/1101708
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Reviewed-by: Justin Novosad <junov@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575462}

TBR=dcheng@chromium.org,enne@chromium.org,fsamuel@chromium.org,junov@chromium.org,mlamouri@chromium.org,liberato@chromium.org,lethalantidote@chromium.org

Change-Id: If2870c03ec0f46546d098cb3fae65edee5b3d772
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1139993
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575573}
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/heads_up_display_layer_impl_unittest.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/layer_impl.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/layer_impl.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/surface_layer.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/surface_layer.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/surface_layer_impl.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/surface_layer_impl_unittest.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/texture_layer_impl.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/test/layer_test_common.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/base/bind_to_current_loop.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/DEPS
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/video_frame_compositor.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/video_frame_compositor.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/public/platform/web_surface_layer_bridge.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/public/platform/web_video_frame_submitter.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/renderer/platform/exported/web_surface_layer_bridge.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/renderer/platform/graphics/video_frame_submitter.h
[modify] https://crrev.com/8d415625cfc8e9befba07b7f107c634f42d0fb44/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

 Issue 864400  has been merged into this issue.
Summary: webkit_layout_tests failing on multiple MSAN bots (was: webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty MSAN)
Owner: mastiz@chromium.org
Status: Started (was: Available)
Status: Fixed (was: Started)
Mergedinto: 864358
Status: Duplicate (was: Fixed)
Issue 864657 has been merged into this issue.

Sign in to add a comment