Regression : 'Advanced' settings doesn't expand after pressing 'Enter' key in chrome://settings page.
Reported by
rp...@etouch.net,
Jul 17
|
|||
Issue descriptionChrome version: 69.0.3494.0 (Official Build)Revision e91414c45bcdc6397f1a38faa0c826fbc47cd772-refs/branch-heads/3494@{#1}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6) What steps will reproduce the problem? 1. Launch chrome,navigate to chrome://settings/ 2. Now bring focus on 'Advanced' button and press 'Enter' key continuously and leave it 3. Now press 'Enter' key once or twice with focus on same 'Advanced' button and observe Actual: 'Advanced' settings doesn't expand after pressing 'Enter' key or clicking on 'Advanced' button Expected: 'Advanced' settings should expand after pressing 'Enter' key or clicking on 'Advanced' button This is regression issue, broken in ‘M 69’ and below is the bisect info : Good build: 69.0.3464.0 (Revision: 567919). Bad build: 69.0.3465.0 (Revision: 568285). You are probably looking for a change made after 568230 (known good), but no later than 568231 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/61f145b51054bf98a726d344055fe1f3e57e9abf..e5d7fdf4d0e68afe341e4cdffedd4469e02a1c63 Suspect : https://chromium.googlesource.com/chromium/src/+/e5d7fdf4d0e68afe341e4cdffedd4469e02a1c63 From the CL above, assigning the issue to the concern owner @aee- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: This issue is also reproducible on M-68 Dev (build # 68.0.3486.0).
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbfaf669bd195b65356a8df39fb0db222f1b6234 commit dbfaf669bd195b65356a8df39fb0db222f1b6234 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Jul 19 07:19:02 2018 Settings: avoid initiating a new toggle while toggling in progress. Bug: 864393 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If82f47605a9cc86e8e1d17e5f6ad1a27027c90b7 Reviewed-on: https://chromium-review.googlesource.com/1141152 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576406} [modify] https://crrev.com/dbfaf669bd195b65356a8df39fb0db222f1b6234/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/dbfaf669bd195b65356a8df39fb0db222f1b6234/chrome/browser/resources/settings/settings_ui/settings_ui.js
,
Jul 19
,
Jul 20
Update : Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.6) OS with latest Canary Chrome version : 69.0.3497.0 and the issue is Fixed.Hence adding TE Verified Label. Kindly refer the attached screen cast for reference. |
|||
►
Sign in to add a comment |
|||
Comment 1 by aee@chromium.org
, Jul 17