New issue
Advanced search Search tips

Issue 864378 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

[iOS] Reading List Bug: Change IsReadingListUIRebootEnabled() to be gated on the UI refresh.

Project Member Reported by kkhorimoto@chromium.org, Jul 17

Issue description

This will enable the new Reading List UI with the rest of the UI phase 1 features.
 
Summary: [iOS] Reading List Bug: Change IsReadingListUIRebootEnabled() to be gated on the UI refresh. (was: [iOS] Reading List Bug: Change IsCollectionsUIRebootEnabled() to be gated on the UI refresh.)
Labels: Proj-UIRefresh Q2 M-69
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cabb24c14909417cb826c4035456be9bcd0a4f3a

commit cabb24c14909417cb826c4035456be9bcd0a4f3a
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Jul 18 19:15:29 2018

[iOS] Update IsReadingListUIRebootEnabled() to use kUIRefreshPhase1.

This enables the table-based Reading List UI to be released with the
rest of the Phase 1 UI Refresh features.

This CL also updates Reading List EGTests to use a11y identifiers for
toolbar buttons rather than labels.  In the UI Refresh, the toolbar
buttons are based on UIBarButtonItems, which are rendered using
multiple views with the same a11y label.  Since EGTests couldn't find
matchers for the label, IDs are used instead.

Bug:  864378 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I223469771314907b614120a6b98f9bb92ce40b25
Reviewed-on: https://chromium-review.googlesource.com/1139901
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576156}
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/feature_engagement/BUILD.gn
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/feature_engagement/feature_engagement_egtest.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/legacy_reading_list_toolbar.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/reading_list_table_view_item.mm
[add] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/reading_list_toolbar_button_identifiers.h
[add] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/reading_list_toolbar_button_identifiers.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/reading_list/reading_list_toolbar_button_manager.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/table_view/cells/BUILD.gn
[add] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/table_view/cells/table_view_url_cell_favicon_badge_view.h
[add] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/table_view/cells/table_view_url_cell_favicon_badge_view.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/table_view/cells/table_view_url_item.h
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
[modify] https://crrev.com/cabb24c14909417cb826c4035456be9bcd0a4f3a/ios/chrome/browser/ui/table_view/table_view_empty_view.mm

Status: Fixed (was: Started)

Sign in to add a comment