New issue
Advanced search Search tips

Issue 864302 link

Starred by 2 users
Status: Fixed
Owner:
skare@chromium.org
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Drive results in Omnibox - tracking bug

Project Member Reported by skare@chromium.org, Jul 17 
Filing this to collect changes for the followon work for experimental Document/Drive provider.

-Scoring needs to be configurable as a study parameter, not hardcoded

-Add icons

-URLs need to be deduped with local history

-Study parameters to reduce traffic [M70?]

Can split this into sub-bugs as neeeded.

Comment 1 by skare@chromium.org, Jul 18 

attaching base CL here too.

Comment 2 by skare@chromium.org, Jul 18

Components: UI>Browser>Omnibox
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13393cb7f0865923c0de422e4e09247eb8bb7eb0

commit 13393cb7f0865923c0de422e4e09247eb8bb7eb0
Author: Travis Skare <skare@chromium.org>
Date: Thu Jul 19 02:47:56 2018

Omnibox document suggestions provider service

Bug:  864302 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibe9a8fdf1ae1c9eb1ef401d3f667f261a76ef65d
Reviewed-on: https://chromium-review.googlesource.com/1069735
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576339}
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/chrome/browser/BUILD.gn
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/chrome/browser/autocomplete/chrome_autocomplete_provider_client.h
[add] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/chrome/browser/autocomplete/document_suggestions_service_factory.cc
[add] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/chrome/browser/autocomplete/document_suggestions_service_factory.h
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_classifier.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_controller.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_controller.h
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_match_type.h
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_provider.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_provider.h
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/autocomplete_provider_client.h
[add] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/document_provider.cc
[add] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/document_provider.h
[add] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/document_provider_unittest.cc
[add] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/document_suggestions_service.cc
[add] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/document_suggestions_service.h
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/mock_autocomplete_provider_client.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/mock_autocomplete_provider_client.h
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/components/omnibox/browser/omnibox_metrics_provider.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.h
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/ios/chrome/browser/ui/omnibox/omnibox_util.cc
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/13393cb7f0865923c0de422e4e09247eb8bb7eb0/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27cee15c401ebe238a04bed165481d38b8974711

commit 27cee15c401ebe238a04bed165481d38b8974711
Author: Travis Skare <skare@chromium.org>
Date: Thu Jul 19 14:34:13 2018

Add client-side setting for omnibox Drive results

Bug:  864302 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: If94e1b5b1cff588da4b83dcee1bdc652889bc05f
Reviewed-on: https://chromium-review.googlesource.com/1141119
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576484}
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/chrome/app/settings_chromium_strings.grdp
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/chrome/app/settings_google_chrome_strings.grdp
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/chrome/app/settings_strings.grdp
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/components/omnibox/browser/document_provider.cc
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/components/omnibox/browser/document_provider.h
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/components/omnibox/browser/document_provider_unittest.cc
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/components/omnibox/browser/omnibox_pref_names.cc
[modify] https://crrev.com/27cee15c401ebe238a04bed165481d38b8974711/components/omnibox/browser/omnibox_pref_names.h
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da23ca67d17abaaf71b3a87b7589f003b0fefcdc

commit da23ca67d17abaaf71b3a87b7589f003b0fefcdc
Author: Travis Skare <skare@chromium.org>
Date: Wed Aug 01 19:49:52 2018

Make DocumentProvider scoring params configurable by study.

Bug:  864302 ,  869221 
Change-Id: I29318c89757dbf21ace69a83519d62d237691f2c
Reviewed-on: https://chromium-review.googlesource.com/1139404
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579905}
[modify] https://crrev.com/da23ca67d17abaaf71b3a87b7589f003b0fefcdc/components/omnibox/browser/document_provider.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 6

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5

commit 2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5
Author: Travis Skare <skare@chromium.org>
Date: Mon Aug 06 14:55:59 2018

Make DocumentProvider scoring params configurable by study.

Bug:  864302 ,  869221 
Change-Id: I29318c89757dbf21ace69a83519d62d237691f2c
Reviewed-on: https://chromium-review.googlesource.com/1139404
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579905}(cherry picked from commit da23ca67d17abaaf71b3a87b7589f003b0fefcdc)
Reviewed-on: https://chromium-review.googlesource.com/1162523
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#416}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5/components/omnibox/browser/document_provider.cc

Comment 7 by skare@chromium.org, Sep 18

Status: Fixed (was: Started)
All items in the catch-all bug were fixed.
►

Sign in to add a comment