New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864291 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Navigation Refresh] Drive should be displayed collapsed

Project Member Reported by lucmult@chromium.org, Jul 17

Issue description

Drive item on navigation should be displayed collapsed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72bc57089b7f5ad6a00fc494c80b507731781f06

commit 72bc57089b7f5ad6a00fc494c80b507731781f06
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Jul 17 07:54:10 2018

Change Drive root to be collapsed by default

Change tests that interact with Drive to expand it when needed.

Bug:  864291 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibd013801c4bb5c1d1f3224707090eaf7ff0009a6
Reviewed-on: https://chromium-review.googlesource.com/1139848
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575574}
[modify] https://crrev.com/72bc57089b7f5ad6a00fc494c80b507731781f06/ui/file_manager/file_manager/background/js/test_util.js
[modify] https://crrev.com/72bc57089b7f5ad6a00fc494c80b507731781f06/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/72bc57089b7f5ad6a00fc494c80b507731781f06/ui/file_manager/integration_tests/file_manager/transfer.js

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca740afdba5cd32ea6eae1b1acaedecbad245699

commit ca740afdba5cd32ea6eae1b1acaedecbad245699
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Jul 19 07:03:03 2018

Keep Drive expanded when My files is disabled

Change NavigationListModel to expose the flag state and use it from
DriveVolumeItem to only expand if My files is disabled.

Fix comment comment changed in crrev.com/c/1141454.

browser tests check for collapsed behaviour.

Test: Manually checked that Drive is expanded when flag is disabled,
Bug:  864291 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iff2c364ce5ad8d50dfd8f7850d9773c8ddf47b3d
Reviewed-on: https://chromium-review.googlesource.com/1143044
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576399}
[modify] https://crrev.com/ca740afdba5cd32ea6eae1b1acaedecbad245699/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
[modify] https://crrev.com/ca740afdba5cd32ea6eae1b1acaedecbad245699/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Sign in to add a comment