New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864267 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 18 days ago
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Chromium Logo Cut Off on chrome://apps

Reported by jeffreyc...@gmail.com, Jul 16

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.59 Safari/537.36

Steps to reproduce the problem:
1. Navigate to chrome://apps
2. Observe bottom-left corner
3. 

What is the expected behavior?
Chromium logo should not be cut off

What went wrong?
Chromium logo is cut off

Did this work before? N/A 

Chrome version: 69.0.3494.0  Channel: canary
OS Version: OS X 10.13.6
Flash Version:
 
Screen Shot 2018-07-16 at 6.23.49 PM.png
152 KB View Download
Labels: Needs-Triage-M69
Components: -UI UI>Browser>NewTabPage Platform>Apps
Cc: phanindra.mandapaka@chromium.org
Labels: Needs-Feedback Triaged-ET
Thanks for filling the issue...

Unable to reproduce the issue on reported chromium version 69.0.3494.0 using Mac 10.13.5. Attaching screen-cast for reference.
Steps: 
---------
1. Launched reported chromium 
2. Navigate to chrome://apps
3. Observe bottom-left corner
As we are able see the Chromium Logo

@Reporter: Request you to retry this issue with fresh profile without any extensions/apps or reset all the flags and let us know if issue still persists.

Thanks.!
864267.mp4
1.2 MB View Download
Can confirm with fresh profile and no extensions, flags it's still happening.

If you do an "Inspect Element" on the logo, then select the parent div like in this screenshot, its width is set to 120px causing it to get cut off.

My screen resolution is the default as viewed from MBP screen (2880 x 1800 Retina).
Screen Shot 2018-07-19 at 8.01.05 AM.png
543 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 19

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: susan.boorgula@chromium.org
Labels: M-69 Target-69 FoundIn-69
Status: Untriaged (was: Unconfirmed)
jeffreyca16@ Thanks for the update.

Able to reproduce this issue on MacBook Pro 10.13.3 High Sierra on the latest Canary 69.0.3496.0 and M-60 chrome build 60.0.3112.0.
Note: Issue is not observed on MacBook Air 10.13.3, Windows 10 and Ubuntu 17.10.

This is a Non-Regression issue as this behavior is observed from M-60 chrome builds.
Hence marking this as Untriaged for further updates from Dev.

Thanks..
864267-M60.png
332 KB View Download
I can try to work on this, should not be a big change
Labels: zine-triaged
Cc: ramyan@chromium.org
Labels: -Pri-2 -Target-69 Hotlist-GoodFirstBug Pri-3
It looks like this is just affecting Chromium releases & not Chrome (which have a shorter name).

Reducing the priority & removing the release target, given the nature of this bug.
Status: Available (was: Untriaged)
Owner: sweilun@chromium.org
Status: Started (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e363c4f7edd2a113698ac99df6670261c3a72b

commit 78e363c4f7edd2a113698ac99df6670261c3a72b
Author: Weilun Shi <sweilun@chromium.org>
Date: Wed Oct 03 21:21:44 2018

[NTP] Wait for chromium logo loaded before adjusting width

The logoImg.complete event was not working as intended on Mac's chromium
chrome://apps. Directly using onload event to adjust the width for the
footer menu and the logo instead.

Screencast:
https://screencast.googleplex.com/cast/NTY2NzA1MTk2ODM5NzMxMnw1ZDVjMjU5NS1jYQ

Bug:  864267 
Change-Id: I614d44c9377e276f6d3084c299ab9ced98ed831d
Reviewed-on: https://chromium-review.googlesource.com/c/1257676
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596368}
[modify] https://crrev.com/78e363c4f7edd2a113698ac99df6670261c3a72b/chrome/browser/resources/ntp4/new_tab.js

Status: Fixed (was: Started)

Sign in to add a comment