New issue
Advanced search Search tips

Issue 864249 link

Starred by 1 user
Status: Fixed
Owner:
thegreenfrog@chromium.org
Closed: Aug 30
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement FaviconLoader for Reading List

Project Member Reported by thegreenfrog@chromium.org, Jul 16 
Right now it uses the old dependence on FaviconAttributes Provider. It makes it hard if we want to coordinate favicon style for Collections. And we're slowly moving all favicons to use one retrieval method.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f22197d18162851ea8c629757b103dee51bc6476

commit f22197d18162851ea8c629757b103dee51bc6476
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Thu Aug 30 01:51:30 2018

[ios] Implement FaviconLoader for ReadingList

This falls in line with the plan to migrate UIRefresh Collections to FaviconLoader as detailed in this doc: https://docs.google.com/document/d/1-c4YEmRta2qcg2HC9VzQZoeI9CBG3yccfN3GBITU910/edit?usp=sharing

Bug:  864249 
Change-Id: I0c0c77be9cb0d86b2bc6b495e015e026709cc354
Reviewed-on: https://chromium-review.googlesource.com/1194581
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587410}
[modify] https://crrev.com/f22197d18162851ea8c629757b103dee51bc6476/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
[modify] https://crrev.com/f22197d18162851ea8c629757b103dee51bc6476/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm
[modify] https://crrev.com/f22197d18162851ea8c629757b103dee51bc6476/ios/chrome/browser/ui/reading_list/reading_list_mediator.h
[modify] https://crrev.com/f22197d18162851ea8c629757b103dee51bc6476/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
[modify] https://crrev.com/f22197d18162851ea8c629757b103dee51bc6476/ios/chrome/browser/ui/reading_list/reading_list_mediator_unittest.mm

Comment 2 by thegreenfrog@chromium.org, Aug 30

Status: Fixed (was: Assigned)
►

Sign in to add a comment