New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 864197 link

Starred by 2 users
Status: Duplicate
Merged: issue 863697
Owner: ----
Closed: Jul 25
Cc:
yyushkina@chromium.org
█ ramyan@chromium.org
markchang@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Bookmark bar icon + text off center

Project Member Reported by bklmn@chromium.org, Jul 16 
What is the expected result?
Bookmark bar to display on NTP

What happens instead?
Bookmark bar displays on NTP, but is misaligned 1px vertically

(redline audit attached)
Screen Shot 2018-07-16 at 12.42.52 PM.png
171 KB View Download

Comment 1 by yyushkina@chromium.org, Jul 17

Cc: markchang@chromium.org
Components: -UI>Browser>NewTabPage UI>Browser>Bookmarks
Labels: -M-69 FoundIn-69
Summary: Bookmark bar icon + text off center (was: [NTP] Bookmark bar icon + text off center)
I think this isn't NTP code, it's bookmarks. Marking untriaged and cc'ing Mark.

Comment 2 by ramyan@chromium.org, Jul 17 

Thanks for filing this Joel!

As Yana mentioned, it is indeed outside the NTP content area. It may also be something that's affected by Views. I think there's currently both Cocoa and Views code to build this:
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm

I'm not sure we'd be the right owners, but also seems like something that can be reviewed M70+, wdyt?
Would this impact available NTP content area on Eve? My reading of the redline is that the overall height doesn't change.

Comment 3 by markchang@chromium.org, Jul 17

Labels: Proj-MdRefresh

Comment 4 by robliao@chromium.org, Jul 17

Labels: Hotlist-Polish
Status: Available (was: Untriaged)
Triage: Unassigning for now.

Comment 5 by meh...@chromium.org, Jul 18 

I think this is the same issue mentioned in  bug 863697 .

This should be fixed in latest Canary in the detached Bookmarks Bar, but there is a regression in the attached Bookmarks Bar now :( See comment 8 & 9 in  bug 863697 .

Comment 6 by ramyan@chromium.org, Jul 19

Owner: ----

Comment 7 by robliao@chromium.org, Jul 19

Labels: Group-Toolbar

Comment 8 by bsep@chromium.org, Jul 25

Mergedinto: 863697
Status: Duplicate (was: Available)
►

Sign in to add a comment