New issue
Advanced search Search tips

Issue 864196 link

Starred by 2 users
Status: Fixed
Owner:
yaoxia@chromium.org
Closed: Aug 6
Cc:
cbiesin...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 864147



Sign in to add a comment

Add UKM for fullscreen

Project Member Reported by csharrison@chromium.org, Jul 16 
We may be able to correlate fullscreen with abuse, especially if we correlate with other signals like engagement.

Abusive sites are known to full-screen without user consent, and users are often confused and don't understand what is happening (or how to exit).

This should be as simple as allowing a few of the fullscreen use counters in UKM (e.g. kFullscreenSecureOrigin/kFullscreenInsecureOrigin).

Comment 1 by e...@chromium.org, Jul 18

Cc: cbiesin...@chromium.org
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)

Comment 2 Deleted

Comment 3 by yaoxia@chromium.org, Jul 25

Owner: yaoxia@chromium.org

Comment 4 Deleted

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66b62dfc9859bb2b77e935d1e70628c9ad4aea7f

commit 66b62dfc9859bb2b77e935d1e70628c9ad4aea7f
Author: Yao Xiao <yaoxia@chromium.org>
Date: Mon Jul 30 19:09:05 2018

Enable UKM metrics for kFullscreenSecureOrigin/kFullscreenInsecureOrigin

(FullscreenSecureOrigin + FullscreenInsecureOrigin) / PageVisits = 1.78%

Bug:  864196 
Change-Id: I88e313288e5d960ba8bc93cef4b45b8a2e6af8ac
Reviewed-on: https://chromium-review.googlesource.com/1151652
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579111}
[modify] https://crrev.com/66b62dfc9859bb2b77e935d1e70628c9ad4aea7f/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc
[modify] https://crrev.com/66b62dfc9859bb2b77e935d1e70628c9ad4aea7f/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/66b62dfc9859bb2b77e935d1e70628c9ad4aea7f/chrome/test/data/page_load_metrics/use_counter_features.html

Comment 6 by benhenry@chromium.org, Aug 2

Status: Assigned (was: Available)

Comment 7 by csharrison@chromium.org, Aug 6

Status: Fixed (was: Assigned)
Fixed, right Yao?

Comment 8 by yaoxia@chromium.org, Aug 6 

@Charlie, if you mean if the fullscreen UKM gets logged, yes.
►

Sign in to add a comment