New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 864195 link

Starred by 1 user
Status: Fixed
Owner:
aleventhal@chromium.org
Closed: Jul 17
Cc:
█ nek...@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

IA2::get_characterExtents() returning incorrect bounds for offscreen chars [regression]

Project Member Reported by aleventhal@chromium.org, Jul 16 
Currently, character extents for offscreen characters return clipped x,y positional info, and width and/or height of 1, depending on whether they are horizontally or vertically offscreen.

The x,y position should be unclipped (allowed to be negative or larger than the screen width/height).
The width/height should not be changed to 1 for offscreen objects.

This information is important for ZoomText's smooth scrolling feature.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84c9263088796f6afea44be5a0db02de8e81b572

commit 84c9263088796f6afea44be5a0db02de8e81b572
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Tue Jul 17 23:01:41 2018

Return unclipped bounds for get_characterExtents

For get_characterExtents():
- The x,y position should be unclipped (allowed to be negative or larger than the screen width/height).
- The width/height should not be changed to 1 for offscreen objects.

Bug:  864195 
Change-Id: Ibea1f3ecb0b8f5f72c6fc967892ac9e6b1af135b
Reviewed-on: https://chromium-review.googlesource.com/1138800
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575831}
[modify] https://crrev.com/84c9263088796f6afea44be5a0db02de8e81b572/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/84c9263088796f6afea44be5a0db02de8e81b572/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/84c9263088796f6afea44be5a0db02de8e81b572/content/browser/accessibility/browser_accessibility.h

Comment 2 by aleventhal@chromium.org, Jul 17

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cbfd306ca28313f8c983d667a77a1384d6589ca

commit 6cbfd306ca28313f8c983d667a77a1384d6589ca
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Jul 17 23:46:26 2018

Revert "Return unclipped bounds for get_characterExtents"

This reverts commit 84c9263088796f6afea44be5a0db02de8e81b572.

Reason for revert: Suspected to cause compile failure at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20Release%20%28Nexus%205X%29/8033

Original change's description:
> Return unclipped bounds for get_characterExtents
> 
> For get_characterExtents():
> - The x,y position should be unclipped (allowed to be negative or larger than the screen width/height).
> - The width/height should not be changed to 1 for offscreen objects.
> 
> Bug:  864195 
> Change-Id: Ibea1f3ecb0b8f5f72c6fc967892ac9e6b1af135b
> Reviewed-on: https://chromium-review.googlesource.com/1138800
> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575831}

TBR=dmazzoni@chromium.org,aleventhal@chromium.org

Change-Id: I5efff2e628b9518039777b8317a581c4c0bc326e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  864195 
Reviewed-on: https://chromium-review.googlesource.com/1140459
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575842}
[modify] https://crrev.com/6cbfd306ca28313f8c983d667a77a1384d6589ca/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/6cbfd306ca28313f8c983d667a77a1384d6589ca/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/6cbfd306ca28313f8c983d667a77a1384d6589ca/content/browser/accessibility/browser_accessibility.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/120547ee53f88db7cf531bc592173507a5645250

commit 120547ee53f88db7cf531bc592173507a5645250
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Jul 23 22:14:03 2018

Reland: Return unclipped bounds for get_characterExtents

For get_characterExtents():
- The x,y position should be unclipped (allowed to be negative or larger than the screen width/height).
- The width/height should not be changed to 1 for offscreen objects.

TBR=dmazzoni@chromium.org

Bug:  864195 
Change-Id: Ib8a57bee7f3b70f46c1c6791ea4c5a294c5ccfe5
Reviewed-on: https://chromium-review.googlesource.com/1146877
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577285}
[modify] https://crrev.com/120547ee53f88db7cf531bc592173507a5645250/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/120547ee53f88db7cf531bc592173507a5645250/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/120547ee53f88db7cf531bc592173507a5645250/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/120547ee53f88db7cf531bc592173507a5645250/content/browser/accessibility/web_contents_accessibility_android.cc
►

Sign in to add a comment