New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 864191 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add a new flag for inserting home page tiles into NTP tiles.

Project Member Reported by romax@chromium.org, Jul 16

Issue description

Being asked by dimich@, a new flag should be added for enabling inserting HomepageTile into Most Visited tiles on NTP page.

This flag should be checked along with NTPButton Enabled flag when deciding if a HomepageClient should be created.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb7663f3431fd1ad9b0f588f1732f4208ac12011

commit bb7663f3431fd1ad9b0f588f1732f4208ac12011
Author: Yafei Duan <romax@chromium.org>
Date: Tue Jul 17 01:33:15 2018

[NTP Tile] Adding flag for homepage tile.

Adding a new flag for controlling whether homepage tile should be used
and inserted into Most Visited tiles on New Tab Page. This will be
checked along with NTPButton Enabled.

Default value is enabled.

Change-Id: I37ba92a2fe0b40c2c682adf1d34d6306242ece53
Bug:  864191 
Reviewed-on: https://chromium-review.googlesource.com/1134587
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575514}
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/browser/about_flags.cc
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/bb7663f3431fd1ad9b0f588f1732f4208ac12011/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment