Sometimes a test got crash/reboot during its run and keyval file of the test didn't generate correctly with all the information needed for further triage/chromeperf upload[1][2]. From the code search, it seems that the sysinfo is gathered 'after' the test. We should gather sysinfo 'before' the test. [1] https://stainless.corp.google.com/browse/chromeos-autotest-results/217641339-chromeos-test/ [2] https://00e9e64bacfd6c5140d19bff123272e5658834a03938d0ff88-apidata.googleusercontent.com/download/storage/v1/b/chromeos-autotest-results/o/217641339-chromeos-test%2Fchromeos4-row11-rack7-host21%2Fgraphics_Drm%2Fkeyval?qk=AD5uMEtZ-PcI4BjcCOZnUGndORA4dlAO7MnEPvdyLKcNPJgtseu4g7JblB0uGJUnBXvQdW-lG7Aa7NcSt4er687CZqqmAg2HsZm3De1j6RHkZLY-5eJ0HhHtfQzxbzGLsuw1mMYcy0u2RyzG_Xbzj8hOdbTKwUr6IHmchW6s0sBUAU2-9BMUlZw1Wj3Uu9HYA2vV58bEduWQfa-vGeMh1LwX0xq1U13coBxmquLtHyfEAQRFRM7UszcpvZX9lzFpgoutf3jnV0KBBwMNj1QxArSphkoMEaZ7V-Ko0zloaX21Ou3AzQtMGtO99vx8237rGDQPsI0WdUSS14-UyC0yUX_OepLvwhE5gd1LssBnkNPhLqiRRDnD8xeFVJPwcIG5A7lAGY5Fit-R5fx70_P59XEA7q2sYg5V28XvtnNt2z33_RNpAb_Vk1Tyf6JVdJSC3Ah9-_21SLLWhoeK31n7-lJhyrBMq5Ob0i5TZhN48k1pSdv1r9W1X-uVkmQ_ZSvD6BvA34YwWC2R1svnCKmRDIz3iOLy18VEedjJbOQYbxDcuHl2nRGVnzMp8UouVkxjBIrIWR-vjf5Y1MGrzkfvtgfUbm21oXHTmZEwBd67yrdw-OA4PZLRgXO4KAcwL8O0IXJ2cUVVvZZI3FOt73baJey8xGJQfV9ripiwRyv54oebrCojZUliS77gJBCyiJpU0Sh2WAuFSR2Zs077SeK8kNc2mD1_6_hg4HXSz0ZXXzxkpWJmreMjkXn3bdKxsssmWAd36-AJ7CFdJvbxOsajqB7y7IjiX2ubQTCYaCaX7bXLzbmbo9zvPI6a4vV2FdPl4kP6qdeB7NGXjz-0JXM-4XkoHCYu6b_16A [3] http://cs/chromeos_public/src/third_party/autotest/files/client/bin/base_sysinfo.py?l=368
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7ed74591aa843651bd4effb08e353a4f507bf22a commit 7ed74591aa843651bd4effb08e353a4f507bf22a Author: Po-Hsien Wang <pwang@chromium.org> Date: Thu Jul 19 09:52:14 2018 sysinfo: Collect sysinfo before tests. Sometime tests got reboot and failed to collect its sysinfo to keyval file, which chromeperf upload relies on. This CL calls the function before the tests. BUG= chromium:864188 TEST=test_that graphics_Drm and check the log. Change-Id: I89d8b826349b078c0121a1c08dacd253be398800 Reviewed-on: https://chromium-review.googlesource.com/1141504 Commit-Ready: Ilja H. Friedel <ihf@chromium.org> Tested-by: Pohsien Wang <pwang@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/7ed74591aa843651bd4effb08e353a4f507bf22a/client/bin/base_sysinfo.py [modify] https://crrev.com/7ed74591aa843651bd4effb08e353a4f507bf22a/client/bin/site_sysinfo.py
This should fix the chromeperf upload issue for some of the reboot case.
Comment 1 by bugdroid1@chromium.org
, Jul 19