Contents are not ready in the first frame |
|||
Issue descriptionChrome Version: ToT OS: Android What steps will reproduce the problem? (1) Disable DON (2) Run test from chrome_public_test_vr_apk VrBrowserWebInputEditingTest#testWebInputFocus What is the expected result? The test runs properly What happens instead? Sometimes, the test crashes because it tries to submit input to the content quad, but it is hidden. Specifically, the DCHECK in UiElement::size fails. This is probably due to the async load of assets. Only when they are loaded, the full UI is visible. We probably need to propagate this value to the tests through the VrShellDelegate.
,
Jul 18
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f750a3a40c6accc0effd03e8804b43904294439 commit 2f750a3a40c6accc0effd03e8804b43904294439 Author: Aldo Culquicondor <acondor@chromium.org> Date: Wed Jul 18 21:09:32 2018 VR: Notify delegate when UI has finished loading This allows the tests to be able to submit events only when the UI is fully loaded. Bug: 864840 , 864161 Change-Id: I41bb0364d3019910fc0b924fd25fe4a9486e6e90 Reviewed-on: https://chromium-review.googlesource.com/1142033 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#576207} [modify] https://crrev.com/2f750a3a40c6accc0effd03e8804b43904294439/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java [modify] https://crrev.com/2f750a3a40c6accc0effd03e8804b43904294439/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java [modify] https://crrev.com/2f750a3a40c6accc0effd03e8804b43904294439/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellImpl.java [modify] https://crrev.com/2f750a3a40c6accc0effd03e8804b43904294439/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/2f750a3a40c6accc0effd03e8804b43904294439/chrome/browser/android/vr/vr_shell.h
,
Jul 18
|
|||
►
Sign in to add a comment |
|||
Comment 1 by acondor@chromium.org
, Jul 16