Add UKM for navigations triggered by ad script |
|||
Issue descriptionWe should add UKM logging the top level frame that initiated a top-level navigation via an ad script (e.g. ad script calling window.open). High counts per origin could be correlated with abusive experiences.
,
Aug 10
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4400d593cd288e6c3bc22adb25282337f0639148 commit 4400d593cd288e6c3bc22adb25282337f0639148 Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Aug 22 15:04:09 2018 Log to ukm if a window.open() navigation is from an ad subframe and if ad script is in stack. Bug: 864160 Change-Id: I6ccac6ae44cfbb0d8bb98d8502b7f85da00479b3 Reviewed-on: https://chromium-review.googlesource.com/1176266 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#585018} [modify] https://crrev.com/4400d593cd288e6c3bc22adb25282337f0639148/chrome/browser/subresource_filter/ad_tagging_browsertest.cc [modify] https://crrev.com/4400d593cd288e6c3bc22adb25282337f0639148/chrome/test/data/ad_tagging/ad_script.js [modify] https://crrev.com/4400d593cd288e6c3bc22adb25282337f0639148/chrome/test/data/ad_tagging/create_frame.js [modify] https://crrev.com/4400d593cd288e6c3bc22adb25282337f0639148/third_party/blink/renderer/core/page/create_window.cc [modify] https://crrev.com/4400d593cd288e6c3bc22adb25282337f0639148/tools/metrics/ukm/ukm.xml
,
Sep 6
|
|||
►
Sign in to add a comment |
|||
Comment 1 by csharrison@chromium.org
, Jul 16