New issue
Advanced search Search tips

Issue 864143 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Consider supporting PIXEL_FORMAT_XRGB in GpuMemoryBufferVideoFramePool

Project Member Reported by mcasas@chromium.org, Jul 16

Issue description

The majority of the cases of GpuMemoryBufferVideoFramePool encountering 
an unsupported pixel format is for XRGB so far: 

https://uma.googleplex.com/p/chrome/histograms/?dayCount=1&histograms=Media.GpuMemoryBufferVideoFramePool.UnsupportedFormat&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

Consider supporting it for the usual benefits of GMBVFPool.
 
As mentioned on issue 864145 I think this is a result of incorrectly creating hardware frames with empty mailboxes (or those mailboxes later getting wiped)
Owner: sande...@chromium.org
sandersd@ to investigate this further.
+mcasas@: It looks like video capture can produce XRGB, SHM-backed frames. Do you think that this could be the primary source of XRGB VideoFrames on Mac?
Cc: chfremer@chromium.org m...@chromium.org
#3: I thought all video capture paths ended up being converted to I420,
+chfremer@, miu@ to confirm or deny
For video capture from physical capture devices, my understanding is that frames are always delivered as shared memory using either I420 or Y16. This conversion happens in class VideoCaptureDeviceClient.

The traditional non-viz capture from desktop/tab/screen etc. also pass through VideoCaptureDeviceClient so they should have the same guarantees. 

DevTools uses ARGB screen capture. But, this does not go through the Video Capture stack (browser->renderer), IIRC.
Status: Assigned (was: Unconfirmed)
Status: Closed (was: Assigned)
I don't see any XRGB counts on any platform since M70. It seems this was fixed some time ago.

Sign in to add a comment