No security impact, approving.

Thanks, katie@!  This largely LGTM.

One issue: We should describe what the behavior here will be if the extension requests VoiceGender after it's removed.  Ideally, we should have this be an undocumented property that's ignored, but won't throw any errors.  Can you add detail on how to handle that?

Additionally, it would be nice if there can be a public version of this doc that we can link on this bug, for any interested parties outside of Google to see.

Thanks Devlin! I'll spec that out. Which doc are you hoping to have publicly available -- the design doc or the motivation/background doc?

Looks like I can just mark the VoiceGender / gender items as 'nodoc': true, and then ignore the values passed. This will hide them from documentation but not throw any errors when the items are used. I will update the design doc to reflect this.

I will land a warning in M70 and fully deprecate in M71, since feature freeze is very soon for M70.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77c48b1fefae15d5863455f1494f4aacc418eb2d

commit 77c48b1fefae15d5863455f1494f4aacc418eb2d
Author: Katie D <katie@chromium.org>
Date: Sat Aug 18 01:50:51 2018

Warns users that VoiceGender is deprecated and will be ignored in Chrome 71.

Warnings occur when loading the manifest or using a chrome.tts or
chrome.ttsEngine Javascript API with VocieGender.

Does not actually deprecate gender, but makes sure it is optional.

BUG= 863999 , 863998 

Change-Id: If850e4374cb871289af0102da18040b49f100ae7
Reviewed-on: https://chromium-review.googlesource.com/1176354
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584280}
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/browser/speech/extension_api/tts_extension_apitest.cc
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/common/extensions/api/speech/tts_engine_manifest_handler.h
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/common/extensions/api/tts.json
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/common/extensions/api/tts_engine.json
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/common/extensions/docs/templates/intros/tts.html
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/common/extensions/docs/templates/intros/ttsEngine.html
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/renderer/resources/extensions/tts_custom_bindings.js
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/renderer/resources/extensions/tts_engine_custom_bindings.js
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/chrome/test/data/extensions/api_test/tts_engine/update_voices_api/test.js
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/extensions/common/manifest_constants.cc
[modify] https://crrev.com/77c48b1fefae15d5863455f1494f4aacc418eb2d/extensions/common/manifest_constants.h

I don't think this has any privacy implications.

The code to do this is in M71 now!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e8c73c30d32ad673497561d27b63ccee88f4b2e

commit 3e8c73c30d32ad673497561d27b63ccee88f4b2e
Author: Katie D <katie@chromium.org>
Date: Tue Sep 04 16:59:20 2018

Deprecates Gender from the TTS and TTS Engine APIs.

Keeps the parameters hidden so that no current implementations will
crash.

Updates documentation to match.

BUG= 863999 , 863998 

Change-Id: Iebbdc6b40018909e806702654a23eb18d2087755
Reviewed-on: https://chromium-review.googlesource.com/1176356
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588552}
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/extension_api/tts_engine_extension_api.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/extension_api/tts_extension_api.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/extension_api/tts_extension_api_constants.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/extension_api/tts_extension_api_constants.h
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/tts_android.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/tts_controller.h
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/tts_controller_impl.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/tts_controller_unittest.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/tts_mac.mm
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/browser/speech/tts_win.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/common/extensions/api/tts.json
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/common/extensions/api/tts_engine.json
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/common/extensions/docs/examples/api/ttsEngine/console_tts_engine/console_tts_engine.html
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/common/extensions/docs/examples/api/ttsEngine/console_tts_engine/console_tts_engine.js
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/test/data/extensions/api_test/tts_engine/register_engine/manifest.json
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/test/data/extensions/api_test/tts_engine/register_engine/test.js
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/test/data/extensions/api_test/tts_engine/update_voices_api/test.js
[delete] https://crrev.com/cad8420a42135039aadcfbe85d2d5976b671927a/chrome/test/data/extensions/manifest_tests/tts_engine_invalid_7.json
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/chrome/test/data/extensions/manifest_tests/tts_engine_valid.json
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/extensions/common/manifest_constants.cc
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/extensions/common/manifest_constants.h
[modify] https://crrev.com/3e8c73c30d32ad673497561d27b63ccee88f4b2e/tools/metrics/histograms/histograms.xml