New issue
Advanced search Search tips

Issue 863971 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

SitePerProcessBrowserTest.ScrollBubblingFromOOPIFWithBodyOverflowHidden failing on chromium.mac/Mac10.12 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 16

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of xiaochengh@chromium.org

Flaky timeouts are seen on Mac.

Builders failed on: 
- Mac10.12 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests


 
Components: Internals>Sandbox>SiteIsolation
Labels: Type-Bug
Owner: wjmaclean@chromium.org
Status: Assigned (was: Available)
Not sure if it's a dupe of  issue 836200 

I'm disabling it on Mac also.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f884126d2ceb5bc9d0287717931f57fce3eb410

commit 9f884126d2ceb5bc9d0287717931f57fce3eb410
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Mon Jul 16 17:48:57 2018

Disable SitePerProcessBrowserTest.ScrollBubblingFromOOPIFWithBodyOverflowHidden on Mac

Bug:  863971 
Change-Id: I7401eaf54693c83145b5a67c17da1ca1e69c9184
Tbr: nasko@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1138376
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575337}
[modify] https://crrev.com/9f884126d2ceb5bc9d0287717931f57fce3eb410/content/browser/site_per_process_browsertest.cc

Labels: -Sheriff-Chromium
Cc: wjmaclean@chromium.org creis@chromium.org
Owner: mcnee@chromium.org
mcnee@ ... could you please triage this?
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5080de388577791818634e8520a506ad30392ed5

commit 5080de388577791818634e8520a506ad30392ed5
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Thu Sep 06 16:01:46 2018

Tentatively re-enable ScrollBubblingFromOOPIFWithBodyOverflowHidden.

It's possible that the change landed in
https://chromium-review.googlesource.com/c/chromium/src/+/1172723
will resolve the flakiness seen in this test. If not, it would be
nice to get some fresh logs from the bots for debugging purposes.

Bug:  863971 
Change-Id: I332b48990e0503e078ccc657d3537c3a6d4f9c7a
Reviewed-on: https://chromium-review.googlesource.com/1210042
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589179}
[modify] https://crrev.com/5080de388577791818634e8520a506ad30392ed5/content/browser/site_per_process_browsertest.cc

Cc: -wjmaclean@chromium.org kenrb@chromium.org mcnee@chromium.org
Labels: OS-Mac
Owner: wjmaclean@chromium.org
Status: Fixed (was: Assigned)
This seems to be running smoothly now on the Mac bots ... marking as fixed. Presumably the fix regarding the changing surface id in the child has helped here.

Please re-open if this looks like it's flaking again.

Sign in to add a comment