New issue
Advanced search Search tips

Issue 863968 link

Starred by 1 user
Status: Assigned
Owner:
nparker@chromium.org
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Make it easier to add file extensions

Project Member Reported by nparker@chromium.org, Jul 16 
For CLs like
https://crrev.com/c/1083313
https://crrev.com/c/1136724
https://crrev.com/c/1091881

It's easy to make mistakes (fixes: https://crrev.com/c/912388, https://crrev.com/c/1083313), and takes several reviewers to update.

We should aim to have one list of file extensions, and have others derived via build-time or run-time tools.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f08e6028ddfb7c7469993377834657bda8237523

commit f08e6028ddfb7c7469993377834657bda8237523
Author: Nathan Parker <nparker@chromium.org>
Date: Mon Jul 16 17:42:19 2018

Add chrome-safebrowsing people to download_stats.cc OWNERS

Bug: 863968
Change-Id: If488c9b2e6f73451d9e72b623be9148dc75ffb29
Reviewed-on: https://chromium-review.googlesource.com/1138639
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575333}
[add] https://crrev.com/f08e6028ddfb7c7469993377834657bda8237523/components/download/internal/common/OWNERS

Comment 2 by vakh@chromium.org, Jul 20

Labels: SafeBrowsing-Triaged
Owner: nparker@chromium.org
Status: Assigned (was: Untriaged)
►

Sign in to add a comment