New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863967 link

Starred by 1 user
Status: Fixed
Owner:
█ sawtelle@google.com
Last visit > 30 days ago
Closed: Aug 10
Cc:
█ apaci...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Picture-in-Picture] Create ability to call setPictureInPictureControls()

Project Member Reported by sawtelle@google.com, Jul 16 
A site should be able to call setPictureInPictureControls() with arbitrary custom controls and have up to 2 appear on the screen near the play/pause button
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e19d11aa341f09676a26faad350b74d7deb2a867

commit e19d11aa341f09676a26faad350b74d7deb2a867
Author: sawtelle <sawtelle@google.com>
Date: Fri Aug 10 03:47:50 2018

[Picture in Picture] Create flow to call setPictureInPictureControls()

This CL creates the option to call setPictureInPictureControls() on an
HTML video element with the desired info for custom controls. An
example of the form this takes can be seen below:

await videoElement.setPictureInPictureControls([
  {
    id: "thumbs-up",
    label: "Thumbs up",
    icons: [
      {
      src: "http://dummyimage.com/96x96",
      sizes: "96x96",
      type: "image/png"
      }
    ]
  }
]);

The actual addition of these controls to the PiP window will come in a
future CL.

Bug:  863967 
Change-Id: I6f6e65a28b546ba31ed67dd4ac92c550a0249b40
Reviewed-on: https://chromium-review.googlesource.com/1138640
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582035}
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/chrome/browser/ui/views/overlay/overlay_window_views.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/common/media/media_player_delegate_messages.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/public/browser/overlay_window.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/public/browser/picture_in_picture_window_controller.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/renderer/media/renderer_webmediaplayer_delegate.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/renderer/media/renderer_webmediaplayer_delegate.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/media/blink/DEPS
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/media/blink/webmediaplayer_delegate.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/public/common/picture_in_picture/picture_in_picture_control_info.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/core/html/media/html_video_element_test.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.idl
[add] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture_test.cc
[add] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_control.idl
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h
[modify] https://crrev.com/e19d11aa341f09676a26faad350b74d7deb2a867/third_party/blink/renderer/platform/testing/empty_web_media_player.h

Comment 2 by sawtelle@google.com, Aug 10

Labels: M-70
Status: Fixed (was: Assigned)
►

Sign in to add a comment