New issue
Advanced search Search tips

Issue 863945 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

use-of-unitialized-value in MediaRouterUIBrowserTest.OpenDialogsInMultipleTabs

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 16

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of xiaochengh@google.com

viz_browser_tests failing on chromium.memory/Linux MSan Tests

Builders failed on: 
- Linux MSan Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests


 
Components: Internals>Cast>UI
Labels: Type-Bug
Owner: taku...@chromium.org
Status: Assigned (was: Available)
Summary: use-of-unitialized-value in MediaRouterUIBrowserTest.OpenDialogsInMultipleTabs (was: viz_browser_tests failing on chromium.memory/Linux MSan Tests)
takumif@: Could you take a look?

The flaky crash is also seen in normal browser_tests:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=MediaRouterUIBrowserTest.OpenDialogsInMultipleTabs

And viz_browser_tests:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=viz_browser_tests&tests=MediaRouterUIBrowserTest.OpenDialogsInMultipleTabs
xialchengh@, when I go to the pages you linked and try to open the failure logs for individual cells, I get a 404 or 503 error. Do you know of a way to get around that?
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d610710ab40ece63c681e3c132a4487e66cd5203

commit d610710ab40ece63c681e3c132a4487e66cd5203
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Mon Jul 16 18:24:29 2018

Disable MediaRouterUIBrowserTest.OpenDialogsInMultipleTabs on MSAN

Bug:  863945 
Change-Id: I1708b8512bea5f86072030a8badb6d09ed261297
NoTry: True
Tbr: takumif@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1138694
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575352}
[modify] https://crrev.com/d610710ab40ece63c681e3c132a4487e66cd5203/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Labels: -Sheriff-Chromium
Cc: powerb@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eed462400adc7478d33776190104ad595879905

commit 7eed462400adc7478d33776190104ad595879905
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Jan 02 20:42:46 2019

Re-enable disabled tests in chrome/browser/ui/views/media_router/.

These pass on Windows.

This requires (mostly) reverting
https://chromium-review.googlesource.com/c/chromium/src/+/1005103 .
The revert is not perfect since many things changed since that CL
initially landed (e.g. various tests got disabled).

Bug:  658005 , 678472, 817408,  828031 ,  843599 ,  849146 ,  863945 
Change-Id: I23a3010be1faf962e0a2dfbaaa4a57a3e2cc89d3
Reviewed-on: https://chromium-review.googlesource.com/c/1351874
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619483}
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/apps/platform_apps/app_window_interactive_uitest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/devtools/devtools_sanity_interactive_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/notifications/notification_interactive_uitest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/exclusive_access/fullscreen_controller_test.h
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/keyboard_lock_interactive_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/presentation_receiver_window_view_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/test/base/in_process_browser_test.h
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment