Background Fetch does not work in Incognito mode |
|||
Issue descriptionBackgroundFetchDownloadClient::OnDownloadSucceeded() gets called when one of the downloads we initiated succeeds. From here, we forward the call to the BackgroundFetchDelegateImpl including the path and size. However, in Incognito mode |download::CompletionInfo.path| will be empty, and |download::CompletionInfo.blob_handle| will be provided instead. We need to read data from that source, and make sure Incognito behaviour is properly tested.
,
Aug 7
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55fd4b8a737bbe8c0ccfed411208ce3f4187aad4 commit 55fd4b8a737bbe8c0ccfed411208ce3f4187aad4 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Sep 03 10:06:31 2018 [Background Fetch] Pass off-the-record state to OfflineItems. Bug: 863939 Change-Id: I54735be657f2b8841de09c0e67738cd1ded1bcf7 Reviewed-on: https://chromium-review.googlesource.com/1194077 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#588361} [modify] https://crrev.com/55fd4b8a737bbe8c0ccfed411208ce3f4187aad4/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/55fd4b8a737bbe8c0ccfed411208ce3f4187aad4/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/55fd4b8a737bbe8c0ccfed411208ce3f4187aad4/chrome/browser/background_fetch/background_fetch_delegate_impl.h
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5f88bd2a45c027898501a46b539b1c4783b1068 commit e5f88bd2a45c027898501a46b539b1c4783b1068 Author: Rayan Kanso <rayankans@chromium.org> Date: Thu Sep 06 18:00:53 2018 [Background Fetch] Pipe through the blob from the download service. In-memory download service (for incognito) returns a blob instead of a file path when the download is complete. This CL passes the value down to the (in memory) DatabaseTasks that expect a valid blob handle. Bug: 863939 Change-Id: I7840c6d6e10ddf883cd44d6eb316a6cc7cbbee47 Reviewed-on: https://chromium-review.googlesource.com/1208171 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#589211} [modify] https://crrev.com/e5f88bd2a45c027898501a46b539b1c4783b1068/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/e5f88bd2a45c027898501a46b539b1c4783b1068/chrome/browser/background_fetch/background_fetch_delegate_impl.h [modify] https://crrev.com/e5f88bd2a45c027898501a46b539b1c4783b1068/chrome/browser/background_fetch/background_fetch_download_client.cc
,
Sep 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by peter@chromium.org
, Jul 16