Clip path for the new dropdown no longer applied on Mac |
||||
Issue descriptionChrome Version: M69 OS: MacOS What steps will reproduce the problem? (1) Enable chrome://flags/#upcoming-ui-features (2) Navigate to https://rsolomakhin.github.io/autofill, scroll up to the top of the page and click on field "Name", section "Profile Autofill" (if you don't see the autofill dropdown, go to chrome://settings/autofill and add a new address) What is the expected result? Dropdown should have corner radius at the bottom and at the top. What happens instead? Corner radius is only shown at the bottom when there is a footer present. This works fine on Windows (tested 69.0.3493.0). Must be a recent regression, since it was working fine only a few weeks ago. Not tested other platforms. Assigning to tmartino@, who is bisecting in order to find the culprit. Adding component "Internals>Views" as well in case this rings a bell for someone on the team.
,
Jul 16
This seems a good candidate to have introduced the regresion: https://chromium.googlesource.com/chromium/src/+/d381a8ca8f8122d0ae4807706b0dd6ee2037db53 - [Autofill Views] Re-reimplement Scrolling
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/013bfb765a78f23c9e82fc13892a82cca41a5dc6 commit 013bfb765a78f23c9e82fc13892a82cca41a5dc6 Author: tmartino <tmartino@chromium.org> Date: Wed Jul 18 17:44:43 2018 [Autofill Views] Fixing Corners/Scrolling Interaction This CL fixes an undesired interaction between the rounded corners and the scroll view in the new dropdown. Specifically, we observed that the clipping path was not being respected on Mac when applied to the contents of the scroll view. This is fixed by applying the existing padding outside, rather than inside, the scroll view, so that the region being clipped is guaranteed to be non-scrollable padding. (n.b.: the padding calculation ensures this is at least as much as large as the corner radius.) This also introduces a minor visual change in the scrolling case only, as the padding above and below the suggestions no longer scrolls along with the suggestions. Besides fixing the clipping bug, on platforms other than Mac this also ensures the top of the scrollbar does not get partially clipped. Change-Id: I6ef7319db094ec66b64859df64031f6330dd567c Bug: 863930 Reviewed-on: https://chromium-review.googlesource.com/1140913 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576123} [modify] https://crrev.com/013bfb765a78f23c9e82fc13892a82cca41a5dc6/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
Jul 18
,
Jul 19
Unable to reproduce the issue on chrome build without fix-69.0.3493.0 using Mac 10.13.5 . Steps: --------- 1. Launched reported chrome 2. Enabled flag upcoming-ui-features 3. Added new address under Chrome://settings/autofill 4. Clicked on the name under Profile Autofill but could not find any difference on the chrome without fix and latest canary 69.0.3496.0. Attaching screenshots for reference. @tmartino : Could you please review the attached screen-shots and confirm if anything being missed here, so that it would be really for further verification Thanks.!
,
Jul 19
The difference is very subtle and easy to miss. Please take a look at the top right corner. In 3496 it looks rounded, whereas in 3493 it doesn't.
,
Jul 19
It may be easier to notice if you change the page background color to dark grey and click on the Address field to show the dropdown. The white bg makes it harder to notice.
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87f5a22a33e38e21521cc61fceff6812b9ab7203 commit 87f5a22a33e38e21521cc61fceff6812b9ab7203 Author: Tommy Martino <tmartino@chromium.org> Date: Fri Jul 20 16:10:44 2018 [Autofill Views] Expanding comment This CL is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/1140913 During review, ftirelo@ requested improvements to documentation. I made, but forgot to upload, those changes prior to landing. This CL corrects that mistake. Change-Id: I2d6c14eff128d5fb26fe70985324203bfedc344d Bug: 863930 Reviewed-on: https://chromium-review.googlesource.com/1144213 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#576887} [modify] https://crrev.com/87f5a22a33e38e21521cc61fceff6812b9ab7203/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
Jul 23
Able to reproduce the issue on Mac 10.12.6 on reported version tested 69.0.3493.0 . Verified the fix on Mac 10.12.6, as per comment#0 on latest chrome version #70.0.3500.0. Attaching screen shot for reference. Observed corner radius at the bottom and at the top for dropdown. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
||||
►
Sign in to add a comment |
||||
Comment 1 by tmartino@chromium.org
, Jul 16