I remember that the NTP string was changed recently for the redesign, which probably caused the different translation.
I we want the same string in both (I'm not sure that we do), we should actually use the same resource.

The intent is for these to be the same so unless there's some language-specific reason they should be different, I think we want to use the same resource in both locations.

ramyan: please me know if you need help from the omnibox team in making this change.

The fakebox string is from IDS_GOOGLE_SEARCH_BOX_EMPTY_HINT_MD in https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?l=4725, "Search Google or type a URL". This corresponds to http://tc/btviewer/messagedetail?project=gws&msgId=6478791167930180244, which does show the German translation in the screenshot for the fakebox. 

Justin - is there a TC link for the Omnibox? Which grd id does Omnibox use?

We worked with Shimi and Mellie on the translations team to ensure that translations on the local and remote NTP are the same. CC'ing Shimi for a heads up on this.

The omnibox string is IDS_OMNIBOX_PLACEHOLDER_TEXT:
https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?l=4668-4670
Unfortunately, I can't figure out how to look up the message ID for the TC.

The issue appears to be that we have a different message because "Google" is a placeholder that we substitute with the name of the user's default search engine (e.g. Bing, Yandex). So to fix it, it seems we'd need to either:

1. Use the *omnibox* message in the fakebox (with the default search engine name always being "Google").
2. Repeat whatever it was you did to get the translations the same for those other two messages, but for the omnibox version.

We documented our process for getting strings into Chrome that can be used in GWS here: https://docs.google.com/document/d/1DuOpOkVmTi_kBOOJeB6aVdgC93PV_szk9n2wxhRPZ1g. This includes a bit of info on where the strings end up in TC.

It looks like this is the IDS_OMNIBOX_PLACEHOLDER_TEXT in TC: http://tc/btviewer/messagedetail?project=ChromeClient&msgId=3932126069013167370

For option (1), I'm not sure how we'd substitute the search engine name into the string in GWS, though I suppose it could be done.

In this case, would it be simpler to have the translation for the fakebox (http://tc/btviewer/messagedetail?project=gws&msgId=6478791167930180244) updated to match what's been created for the Omnibox? Given that the context for both is the same, it seems like the translations should be identical.

Shimi - is this possible? 

Temporarily reducing the priority while we work on any issues that may need to be merged.

Should this bug still be assigned to Shimi?

Mellie, Shimi: 

We manually need to make sure that the translations for these fakebox message IDs (https://tc.corp.google.com/btviewer/searchresult?SearchText=search%20google%20or%20type%20url&SearchField=search_field_src_and_trans&SearchType=search_type_token_and_phrase&ProductSelect&TranslationFilterStatus=translated&TranslationFilterAnyOrAll=any&TranslationFilterStage=LEVERAGED&ShowTranslationStage=showTranslationStage&CreatedAfter&CreatedBefore&ResourcesFilter) match the ones in Omnibox (https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=3932126069013167370) when SEARCH_ENGINE_NAME is Google.

Can that be done?

Hi all,

Can you please clarify what is the suggested translation? 

Is it the translation from this TC.https://tc.corp.google.com/btviewer/edittranslation?project=ChromeClient&msgId=6478791167930180244&language=de ( Mit Google suchen oder eine URL eingeben ) or from the translation of this TC
https://tc.corp.google.com/btviewer/edittranslation?project=ChromeClient&msgId=3932126069013167370&language=de ( SEARCH_ENGINE_NAME durchsuchen oder URL eingeben )?

Note that the other TC includes a placeholder that cannot be edited by our linguist.

Regards!

I believe this one. https://tc.corp.google.com/btviewer/edittranslation?project=ChromeClient&msgId=6478791167930180244&language=de

But to clarify: we need to make sure that FOR ALL LANGUAGES these two strings match when SEARCH_ENGINE_NAME is Google.

And when I say match in this case:
The first Translation stays the same: "Mit Google suchen oder eine URL eingeben"
The second would then need to be "Mit SEARCH_ENGINE_NAME suchen oder eine URL eingeben." and need to make sense in German (which I don't speak)

Hi,

 I have forwarded this issue to the locale POC for TC editing. I'll update you once it is done.

b/112553308

Regards!

Hi,

The bug was fixed by our linguist. Let us know if you have questions!

Regards!