New issue
Advanced search Search tips

Issue 863885 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

NotificationPlatformBridgeTest#testShowNotificationWithoutIcon fails on Nexus 5x

Project Member Reported by awdf@chromium.org, Jul 16

Issue description

Chrome Version: ToT refs/heads/master@{#574880}

OS: Android 8.1.0.OPM4.171019.021

What steps will reproduce the problem?

ninja -C out/AndroidDebug -j2000 -l20 chrome_public_test_apk &&  out/AndroidDebug/bin/run_chrome_public_test_apk --test-filter "*NotificationPlatformBridgeTest#testShowNotificationWithoutIcon*" --local-output --no-retry

What is the expected result?

Test passes

What happens instead?

Test fails at 

l687:  
Assert.assertTrue(generatedIcon.sameAs(NotificationTestUtil.getLargeIconFromNotification(context, notification)))

But weirdly, this passes on the bots (even the Oreo bot)

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=instrumentation&tests=org.chromium.chrome.browser.notifications.NotificationPlatformBridgeTest%23testShowNotificationWithoutIcon

Will flash to the latest public release of Oreo and see if that resolves things..
 
Still fails on OPM6.171019.030.E1 
Owner: peter@chromium.org
Turns out the generated icon on the notification shown has different dimensions from the one generated to compare it to, I'm not sure why. I wonder if we should just relax the test expectation to check dimensions are >0 rather than try to match the bitmaps exactly.

Sign in to add a comment