New issue
Advanced search Search tips

Issue 863871 link

Starred by 1 user
Status: WontFix
Owner:
mrsuyi@chromium.org
Closed: Jul 16
Cc:
marq@chromium.org
justincohen@chromium.org
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Too many definitions of "Cancel" in ios/chrome/app/strings/ios_strings.grd

Project Member Reported by mrsuyi@chromium.org, Jul 16 
Chrome Version: (69.0.3489.0)
OS: (iOS)

What steps will reproduce the problem?
  1. Check the ios/chrome/app/strings/ios_string.grd. There are 7 <message>s that have the value of "Cancel".

Comment 1 by rohitrao@chromium.org, Jul 16 

Is this causing specific problems?

The duplication doesn't bother me.  I think the additional translation cost is minimal, the effect on binary size is minimal, and there's a benefit in having separate strings for each feature, so that it's easier to change one without changing all the others.  (Put another way -- is the word "Cancel" an implementation detail of each feature, something that might change in the future?)

Comment 2 by mrsuyi@chromium.org, Jul 16 

It's first discussed here:

https://chromium-review.googlesource.com/c/chromium/src/+/1135308/4/ios/chrome/app/strings/ios_strings.grd#538

I don't know about other "Cancel"s' context, maybe only a few of them are redundant?

Comment 3 by pkl@chromium.org, Jul 16

Status: WontFix (was: Untriaged)
Depending on the context, "Cancel" may be translated differently for different languages. So, it is better to keep them separate but make sure that the descriptions are useful to translators, i.e. enough context for "Cancel" to be translated properly.
►

Sign in to add a comment