New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863870 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Track sessions earlier (and remove enum StopSyncResponse)

Project Member Reported by mastiz@chromium.org, Jul 16

Issue description

Enum StopSyncResponse seemed to make sense at the time it was introduced, motivated by sessions sync, but it has recently conflicted with new features and the code in ClientTagBasedModelTypeProcessor has gone out of hands.

It seems like the enum has reasonable alternatives these days: creating the leveldb itself is not expensive, even reading sync metadata, and from that point on it is simple to optimize the codepath for non-sync users, which was the main motivation for the optimization in place.

For sync users, it's questionable whether we want to defer work until sync engine itself starts. 
 
Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Triage ping: Is this still relevant? Is it a P2?
Labels: -Pri-2 Pri-3
Sorry for the long silence. The bug is still relevant and worth doing, but adjusting to P3.

Sign in to add a comment