ios_chrome_unified_consent_egtests failing on iPhones |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of stkhapugin@chromium.org ios_chrome_unified_consent_egtests (iPhone 5s iOS 11.2) on Mac failing on internal.bling.main/iphone11-simulator-x64 Builders failed on: - iphone11-simulator-x64: https://ci.chromium.org/buildbot/internal.bling.main/iphone11-simulator-x64 - iphone10-simulator-x64: https://ci.chromium.org/buildbot/internal.bling.main/iphone10-simulator-x64 - iphone10-simulator: https://ci.chromium.org/buildbot/internal.bling.main/iphone10-simulator Seems like "Non-personalized Services" label is not interactable.
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/950cf29752af56ddb040f7e75bbf684dac7ad5be commit 950cf29752af56ddb040f7e75bbf684dac7ad5be Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Mon Jul 16 13:54:35 2018 Disable testServicesWhileSignedOut on iPhones. This test is consistently failing on all iPhone simulators, including iOS beta bots. Bug: 863860 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie4b289fca1743a3c14acb5ae50d9a50719c9ac5a Reviewed-on: https://chromium-review.googlesource.com/1138242 Reviewed-by: Eric Noyau <noyau@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575242} [modify] https://crrev.com/950cf29752af56ddb040f7e75bbf684dac7ad5be/ios/chrome/browser/ui/settings/google_services_settings_egtest.mm
,
Jul 18
Hi jlebel@, stkhapugin@, any update here? First beta is scheduled for next Wednesday 7/25.
,
Jul 19
Sorry, for not giving updates. This test is not useful for the beta. It tests code that is still under development for a UI that is not used. It should not block the beta.
,
Jul 19
,
Jul 19
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f33b43a32d641a90da78a6035a36f70e975929d commit 7f33b43a32d641a90da78a6035a36f70e975929d Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Jul 24 10:29:18 2018 [iOS] Fixing collapsible sections in Sync and Google Services When signed out: - personalized section should be collapsed - non-personalized should be expanded When signed-in with no consent given: - personalized section should be expanded - non-personalized should be expanded When signed-in with consent given: - personalized section should be collapsed - non-personalized should be collapsed Bug: 849838, 863860 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4fa468253606c431684d0c8b19bcf4548dcf4ad7 Reviewed-on: https://chromium-review.googlesource.com/1133171 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577477} [modify] https://crrev.com/7f33b43a32d641a90da78a6035a36f70e975929d/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/7f33b43a32d641a90da78a6035a36f70e975929d/ios/chrome/browser/ui/settings/google_services_settings_coordinator.mm [modify] https://crrev.com/7f33b43a32d641a90da78a6035a36f70e975929d/ios/chrome/browser/ui/settings/google_services_settings_egtest.mm [modify] https://crrev.com/7f33b43a32d641a90da78a6035a36f70e975929d/ios/chrome/browser/ui/settings/google_services_settings_mediator.h [modify] https://crrev.com/7f33b43a32d641a90da78a6035a36f70e975929d/ios/chrome/browser/ui/settings/google_services_settings_mediator.mm
,
Jul 25
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by stkhapugin@chromium.org
, Jul 16Labels: ReleaseBlock-Beta M-69 OS-iOS
Owner: jlebel@chromium.org
Status: Assigned (was: Available)